Quellcode durchsuchen

Fix user order history view in case the filtering form is not valid

master
Asia Biega vor 13 Jahren
Ursprung
Commit
0bd3bebe16
2 geänderte Dateien mit 4 neuen und 3 gelöschten Zeilen
  1. 1
    1
      oscar/apps/customer/forms.py
  2. 3
    2
      oscar/apps/customer/views.py

+ 1
- 1
oscar/apps/customer/forms.py Datei anzeigen

@@ -110,7 +110,7 @@ class SearchByDateRangeForm(forms.Form):
110 110
         return super(SearchByDateRangeForm, self).clean()
111 111
 
112 112
     def description(self):
113
-        if not self.is_bound:
113
+        if not self.is_bound or not self.is_valid():
114 114
             return 'All orders'
115 115
         date_from = self.cleaned_data['date_from']
116 116
         date_to = self.cleaned_data['date_to']

+ 3
- 2
oscar/apps/customer/views.py Datei anzeigen

@@ -291,7 +291,8 @@ class OrderHistoryView(ListView):
291 291
         if 'date_from' in request.GET:
292 292
             self.form = SearchByDateRangeForm(self.request.GET)
293 293
             if not self.form.is_valid():
294
-                ctx = self.get_context_data()
294
+                self.object_list = self.get_queryset()
295
+                ctx = self.get_context_data(object_list=self.object_list)
295 296
                 return self.render_to_response(ctx)
296 297
         else:
297 298
             self.form = SearchByDateRangeForm()
@@ -299,7 +300,7 @@ class OrderHistoryView(ListView):
299 300
 
300 301
     def get_queryset(self):
301 302
         qs = self.model._default_manager.filter(user=self.request.user)
302
-        if self.form.is_bound:
303
+        if self.form.is_bound and self.form.is_valid():
303 304
             qs = qs.filter(**self.form.get_filters())
304 305
         return qs
305 306
 

Laden…
Abbrechen
Speichern