소스 검색

Fixed circular reference problem from CC project. Caused by import of

model from within forms.validators
master
David Winterbottom 13 년 전
부모
커밋
102904261c
2개의 변경된 파일4개의 추가작업 그리고 6개의 파일을 삭제
  1. 2
    2
      oscar/apps/checkout/views.py
  2. 2
    4
      oscar/core/validators.py

+ 2
- 2
oscar/apps/checkout/views.py 파일 보기

653
         """
653
         """
654
         # Check that shipping address has been completed
654
         # Check that shipping address has been completed
655
         if not self.checkout_session.is_shipping_address_set():
655
         if not self.checkout_session.is_shipping_address_set():
656
-            messages.error(request, _("Please choose a shipping address"))
656
+            messages.error(self.request, _("Please choose a shipping address"))
657
             return HttpResponseRedirect(reverse('checkout:shipping-address'))
657
             return HttpResponseRedirect(reverse('checkout:shipping-address'))
658
         # Check that shipping method has been set
658
         # Check that shipping method has been set
659
         if not self.checkout_session.is_shipping_method_set():
659
         if not self.checkout_session.is_shipping_method_set():
660
-            messages.error(request, _("Please choose a shipping method"))
660
+            messages.error(self.request, _("Please choose a shipping method"))
661
             return HttpResponseRedirect(reverse('checkout:shipping-method'))
661
             return HttpResponseRedirect(reverse('checkout:shipping-method'))
662
         # Next, check that basket isn't empty
662
         # Next, check that basket isn't empty
663
         if basket.is_empty:
663
         if basket.is_empty:

+ 2
- 4
oscar/core/validators.py 파일 보기

8
 
8
 
9
 from django.db.models import get_model
9
 from django.db.models import get_model
10
 
10
 
11
-# FlatPages is None if not installed
12
-FlatPage = get_model('flatpages', 'FlatPage')
13
-
14
 
11
 
15
 class ExtendedURLValidator(validators.URLValidator):
12
 class ExtendedURLValidator(validators.URLValidator):
16
     def __call__(self, value):
13
     def __call__(self, value):
32
                 resolve(value)
29
                 resolve(value)
33
             self.is_local_url = True
30
             self.is_local_url = True
34
         except Http404:
31
         except Http404:
35
-            # check for existing urls of flatpages if package installed
32
+            # FlatPages is None if not installed
33
+            FlatPage = get_model('flatpages', 'FlatPage')
36
             if FlatPage is not None:
34
             if FlatPage is not None:
37
                 for page in FlatPage.objects.all().only(('url')):
35
                 for page in FlatPage.objects.all().only(('url')):
38
                     if value == page.url:
36
                     if value == page.url:

Loading…
취소
저장