Przeglądaj źródła

Assert tax must be set before submission (not in dispatch)

master
David Winterbottom 12 lat temu
rodzic
commit
1dfbade229
1 zmienionych plików z 6 dodań i 5 usunięć
  1. 6
    5
      oscar/apps/checkout/views.py

+ 6
- 5
oscar/apps/checkout/views.py Wyświetl plik

@@ -361,10 +361,6 @@ class PaymentDetailsView(OrderPlacementMixin, TemplateView):
361 361
     preview = False
362 362
 
363 363
     def dispatch(self, request, *args, **kwargs):
364
-        # Taxes must be known at this point
365
-        assert request.basket.is_tax_known, (
366
-            "Tax must be set before a user can place an order")
367
-
368 364
         error_response = self.get_error_response()
369 365
         if error_response:
370 366
             return error_response
@@ -486,6 +482,10 @@ class PaymentDetailsView(OrderPlacementMixin, TemplateView):
486 482
         if order_kwargs is None:
487 483
             order_kwargs = {}
488 484
 
485
+        # Taxes must be known at this point
486
+        assert basket.is_tax_known, (
487
+            "Tax must be set before a user can place an order")
488
+
489 489
         # Domain-specific checks on the basket
490 490
         is_valid, reason, url = self.can_basket_be_submitted(basket)
491 491
         if not is_valid:
@@ -499,7 +499,8 @@ class PaymentDetailsView(OrderPlacementMixin, TemplateView):
499 499
         # the order on a different request).
500 500
         order_number = self.generate_order_number(basket)
501 501
         self.checkout_session.set_order_number(order_number)
502
-        logger.info("Order #%s: beginning submission process for basket #%d", order_number, basket.id)
502
+        logger.info("Order #%s: beginning submission process for basket #%d",
503
+                    order_number, basket.id)
503 504
 
504 505
         # Freeze the basket so it cannot be manipulated while the customer is
505 506
         # completing payment on a 3rd party site.  Also, store a reference to

Ładowanie…
Anuluj
Zapisz