Rewrite checkout functional tests

We no longer use Django's test client.

oscar/apps/basket/forms.py

@@ -1,9 +1,9 @@
 from django import forms
 from django.conf import settings
-from oscar.core.loading import get_model
 from django.forms.models import modelformset_factory, BaseModelFormSet
 from django.utils.translation import ugettext_lazy as _
 
+from oscar.core.loading import get_model
 from oscar.forms import widgets
 
 Line = get_model('basket', 'line')

oscar/templates/oscar/basket/basket.html

@@ -32,7 +32,7 @@
     {{ block.super }}
     {# We pass in the URL to send AJAX requests to #}
     var options = {
-    'basketURL': '{% url 'basket:summary' %}'
+        'basketURL': '{% url 'basket:summary' %}'
     };
     oscar.basket.init(options);
 {% endblock %}

oscar/templates/oscar/basket/partials/basket_content.html

@@ -114,7 +114,7 @@
 
                 <div id="voucher_form_container" style="display:none">
                     <h4>{% trans "Voucher code" %}</h4>
-                    <form action="{% url 'basket:vouchers-add' %}" method="post">
+                    <form id="voucher_form" action="{% url 'basket:vouchers-add' %}" method="post">
                         {% csrf_token %}
                         {% include "partials/form_fields.html" with form=voucher_form %}
                         <button type="submit" class="btn btn-info">{% trans "Add voucher" %}</button>

tests/functional/checkout/__init__.py

@@ -0,0 +1,61 @@
+from decimal import Decimal as D
+
+from django.core.urlresolvers import reverse
+
+from oscar.apps.address.models import Country
+from oscar.test import factories
+
+
+class CheckoutMixin(object):
+
+    def create_digital_product(self):
+        product = factories.create_product(price=D('12.00'), num_in_stock=None)
+        product.product_class.requires_shipping = False
+        product.product_class.track_stock = False
+        product.product_class.save()
+        return product
+
+    def add_product_to_basket(self, product=None):
+        if product is None:
+            product = factories.create_product(price=D('12.00'),
+                                               num_in_stock=10)
+        detail_page = self.get(product.get_absolute_url())
+        form = detail_page.forms['add_to_basket_form']
+        form.submit()
+
+    def add_voucher_to_basket(self, voucher=None):
+        if voucher is None:
+            voucher = factories.create_voucher()
+        basket_page = self.get(reverse('basket:summary'))
+        form = basket_page.forms['voucher_form']
+        form['code'] = voucher.code
+        form.submit()
+
+    def enter_guest_details(self, email='guest@example.com'):
+        index_page = self.get(reverse('checkout:index'))
+        index_page.form['username'] = email
+        index_page.form.submit()
+
+    def create_shipping_country(self):
+        Country.objects.get_or_create(
+            iso_3166_1_a2='GB', is_shipping_country=True)
+
+    def enter_shipping_address(self):
+        self.create_shipping_country()
+        address_page = self.get(reverse('checkout:shipping-address'))
+        form = address_page.forms['new_shipping_address']
+        form['first_name'] = 'John'
+        form['last_name'] = 'Doe'
+        form['line1'] = '1 Egg Road'
+        form['line4'] = 'Shell City'
+        form['postcode'] = 'N12 9RT'
+        form.submit()
+
+    def enter_shipping_method(self):
+        self.get(reverse('checkout:shipping-method'))
+
+    def place_order(self):
+        payment_details = self.get(
+            reverse('checkout:shipping-method')).follow().follow()
+        preview = payment_details.click(linkid="view_preview")
+        return preview.forms['place-order-form'].submit().follow()

tests/functional/checkout/checkout_tests.py

@@ -1,289 +0,0 @@
-from decimal import Decimal as D
-import sys
-
-from django.core.urlresolvers import reverse
-from django.conf import settings
-from django.utils.importlib import import_module
-from django.test.utils import override_settings
-
-from oscar.test.factories import (
-    create_product, create_voucher, create_offer)
-from oscar.test.testcases import WebTestCase
-from oscar.apps.basket.models import Basket
-from oscar.apps.order.models import Order
-from oscar.apps.address.models import Country
-from oscar.apps.voucher.models import Voucher
-from oscar.apps.offer.models import ConditionalOffer
-from oscar.test.basket import add_product
-
-# Python 3 compat
-try:
-    from imp import reload
-except ImportError:
-    pass
-
-
-class CheckoutMixin(object):
-
-    def add_product_to_basket(self):
-        product = create_product(price=D('12.00'), num_in_stock=10)
-        self.client.post(reverse('basket:add'), {'product_id': product.id,
-                                                 'quantity': 1})
-
-    def add_voucher_to_basket(self, voucher=None):
-        if voucher is None:
-            voucher = create_voucher()
-        self.client.post(reverse('basket:vouchers-add'),
-                         {'code': voucher.code})
-
-    def complete_guest_email_form(self, email='test@example.com'):
-        response = self.client.post(reverse('checkout:index'),
-                                    {'username': email,
-                                     'options': 'new'})
-        self.assertIsRedirect(response)
-
-    def complete_shipping_address(self):
-        Country.objects.get_or_create(
-            iso_3166_1_a2='GB',
-            is_shipping_country=True
-        )
-        response = self.client.post(reverse('checkout:shipping-address'),
-                                     {'last_name': 'Doe',
-                                      'first_name': 'John',
-                                      'line1': '1 Egg Street',
-                                      'line4': 'City',
-                                      'postcode': 'N1 9RT',
-                                      'country': 'GB',
-                                     })
-        self.assertRedirectUrlName(response, 'checkout:shipping-method')
-
-    def complete_shipping_method(self):
-        self.client.get(reverse('checkout:shipping-method'))
-
-    def submit(self):
-        return self.client.post(reverse('checkout:preview'), {'action': 'place_order'})
-
-
-class DisabledAnonymousCheckoutViewsTests(WebTestCase):
-    is_anonymous = True
-
-    def test_index_does_require_login(self):
-        url = reverse('checkout:index')
-        response = self.client.get(url)
-        self.assertIsRedirect(response)
-
-    def test_user_address_views_require_a_login(self):
-        urls = [reverse('checkout:user-address-update', kwargs={'pk': 1}),
-                reverse('checkout:user-address-delete', kwargs={'pk': 1}),]
-        for url in urls:
-            response = self.client.get(url)
-            self.assertIsRedirect(response)
-
-    def test_core_checkout_requires_login(self):
-        urls = [reverse('checkout:shipping-address'),
-                reverse('checkout:payment-method'),
-                reverse('checkout:shipping-method'),
-                reverse('checkout:payment-details')]
-        for url in urls:
-            response = self.client.get(url)
-            self.assertIsRedirect(response)
-
-
-class TestShippingAddressView(WebTestCase, CheckoutMixin):
-    fixtures = ['countries.json']
-
-    def test_pages_returns_200(self):
-        self.add_product_to_basket()
-        response = self.client.get(reverse('checkout:shipping-address'))
-        self.assertIsOk(response)
-
-    def test_anon_checkout_disabled_by_default(self):
-        self.assertFalse(settings.OSCAR_ALLOW_ANON_CHECKOUT)
-
-    def test_create_shipping_address_adds_address_to_session(self):
-        self.add_product_to_basket()
-        response = self.client.post(reverse('checkout:shipping-address'),
-                                            {'last_name': 'Doe',
-                                             'first_name': 'John',
-                                             'line1': '1 Egg Street',
-                                             'line4': 'City',
-                                             'postcode': 'N1 9RT',
-                                             'country': 'GB',
-                                            })
-        self.assertIsRedirect(response)
-        session_address = self.client.session['checkout_data']['shipping']['new_address_fields']
-        self.assertEqual('Doe', session_address['last_name'])
-        self.assertEqual('1 Egg Street', session_address['line1'])
-        self.assertEqual('N1 9RT', session_address['postcode'])
-
-    def test_invalid_shipping_address_fails(self):
-        self.add_product_to_basket()
-        response = self.client.post(reverse('checkout:shipping-address'),
-                                    {'last_name': 'Doe',
-                                     'first_name': 'John',
-                                     'postcode': 'N1 9RT',
-                                     'country': 'GB',
-                                     })
-        self.assertIsOk(response)  # no redirect
-
-    def test_user_must_have_a_nonempty_basket(self):
-        response = self.client.get(reverse('checkout:shipping-address'))
-        self.assertRedirectUrlName(response, 'basket:summary')
-
-
-class TestShippingMethodView(WebTestCase, CheckoutMixin):
-    fixtures = ['countries.json']
-
-    def test_shipping_method_view_redirects_if_no_shipping_address(self):
-        self.add_product_to_basket()
-        response = self.client.get(reverse('checkout:shipping-method'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-address')
-
-    def test_redirects_by_default(self):
-        self.add_product_to_basket()
-        self.complete_shipping_address()
-        response = self.client.get(reverse('checkout:shipping-method'))
-        self.assertRedirectUrlName(response, 'checkout:payment-method')
-
-    def test_user_must_have_a_nonempty_basket(self):
-        response = self.client.get(reverse('checkout:shipping-method'))
-        self.assertRedirectUrlName(response, 'basket:summary')
-
-
-class TestPaymentMethodView(WebTestCase, CheckoutMixin):
-
-    def test_view_redirects_if_no_shipping_address(self):
-        self.add_product_to_basket()
-        response = self.client.get(reverse('checkout:payment-method'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-address')
-
-    def test_view_redirects_if_no_shipping_method(self):
-        self.add_product_to_basket()
-        self.complete_shipping_address()
-        response = self.client.get(reverse('checkout:payment-method'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-method')
-
-    def test_user_must_have_a_nonempty_basket(self):
-        response = self.client.get(reverse('checkout:payment-method'))
-        self.assertRedirectUrlName(response, 'basket:summary')
-
-
-class TestPreviewView(WebTestCase, CheckoutMixin):
-
-    def test_user_must_have_a_nonempty_basket(self):
-        response = self.client.get(reverse('checkout:preview'))
-        self.assertRedirectUrlName(response, 'basket:summary')
-
-    def test_view_redirects_if_no_shipping_address(self):
-        self.add_product_to_basket()
-        response = self.client.get(reverse('checkout:preview'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-address')
-
-    def test_view_redirects_if_no_shipping_method(self):
-        self.add_product_to_basket()
-        self.complete_shipping_address()
-        response = self.client.get(reverse('checkout:preview'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-method')
-
-    def test_ok_response_if_previous_steps_complete(self):
-        self.add_product_to_basket()
-        self.complete_shipping_address()
-        self.complete_shipping_method()
-        response = self.client.get(reverse('checkout:preview'))
-        self.assertIsOk(response)
-
-
-class TestPaymentDetailsView(WebTestCase, CheckoutMixin):
-
-    def test_user_must_have_a_nonempty_basket(self):
-        response = self.client.get(reverse('checkout:payment-details'))
-        self.assertRedirectUrlName(response, 'basket:summary')
-
-    def test_view_redirects_if_no_shipping_address(self):
-        self.add_product_to_basket()
-        response = self.client.post(reverse('checkout:payment-details'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-address')
-
-    def test_view_redirects_if_no_shipping_method(self):
-        self.add_product_to_basket()
-        self.complete_shipping_address()
-        response = self.client.post(reverse('checkout:payment-details'))
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'checkout:shipping-method')
-
-    def test_placing_order_with_empty_basket_redirects(self):
-        response = self.client.post(reverse('checkout:preview'), {'action': 'place_order'})
-        self.assertIsRedirect(response)
-        self.assertRedirectUrlName(response, 'basket:summary')
-
-
-class TestOrderPlacement(WebTestCase, CheckoutMixin):
-
-    def setUp(self):
-        super(TestOrderPlacement, self).setUp()
-        self.basket = Basket.objects.create(owner=self.user)
-        add_product(self.basket, D('12.00'))
-
-        self.complete_shipping_address()
-        self.complete_shipping_method()
-        self.response = self.client.post(reverse('checkout:preview'), {'action': 'place_order'})
-
-    def test_placing_order_with_nonempty_basket_redirects(self):
-        self.assertIsRedirect(self.response)
-        self.assertRedirectUrlName(self.response, 'checkout:thank-you')
-
-    def test_order_is_created(self):
-        self.assertIsRedirect(self.response)
-        orders = Order.objects.all()
-        self.assertEqual(1, len(orders))
-
-
-class TestPlacingOrderUsingAVoucher(WebTestCase, CheckoutMixin):
-
-    def setUp(self):
-        super(TestPlacingOrderUsingAVoucher, self).setUp()
-        self.add_product_to_basket()
-        voucher = create_voucher()
-        self.add_voucher_to_basket(voucher)
-        self.complete_shipping_address()
-        self.complete_shipping_method()
-        self.response = self.submit()
-
-        # Reload voucher
-        self.voucher = Voucher.objects.get(id=voucher.id)
-
-    def test_is_successful(self):
-        self.assertRedirectUrlName(self.response, 'checkout:thank-you')
-
-    def test_records_use(self):
-        self.assertEqual(1, self.voucher.num_orders)
-
-    def test_records_discount(self):
-        self.assertEqual(1, self.voucher.num_orders)
-
-
-class TestPlacingOrderUsingAnOffer(WebTestCase, CheckoutMixin):
-
-    def setUp(self):
-        super(TestPlacingOrderUsingAnOffer, self).setUp()
-        offer = create_offer()
-        self.add_product_to_basket()
-        self.complete_shipping_address()
-        self.complete_shipping_method()
-        self.response = self.submit()
-
-        # Reload offer
-        self.offer = ConditionalOffer.objects.get(id=offer.id)
-
-    def test_is_successful(self):
-        self.assertRedirectUrlName(self.response, 'checkout:thank-you')
-
-    def test_records_use(self):
-        self.assertEqual(1, self.offer.num_orders)
-        self.assertEqual(1, self.offer.num_applications)

tests/functional/checkout/customer_checkout_tests.py

@@ -0,0 +1,112 @@
+from django.core.urlresolvers import reverse
+
+from oscar.test.testcases import WebTestCase
+from oscar.test import factories
+from oscar.apps.order.models import Order
+from oscar.apps.offer.models import ConditionalOffer
+from . import CheckoutMixin
+
+
+class TestIndexView(CheckoutMixin, WebTestCase):
+
+    def test_requires_login(self):
+        response = self.get(reverse('checkout:index'), user=None)
+        self.assertIsRedirect(response)
+
+    def test_redirects_customers_with_empty_basket(self):
+        response = self.get(reverse('checkout:index'))
+        self.assertRedirectUrlName(response, 'basket:summary')
+
+    def test_redirects_customers_to_shipping_address_view(self):
+        self.add_product_to_basket()
+        response = self.get(reverse('checkout:index'))
+        self.assertRedirectUrlName(response, 'checkout:shipping-address')
+
+
+class TestShippingAddressView(CheckoutMixin, WebTestCase):
+
+    def setUp(self):
+        self.create_shipping_country()
+        super(TestShippingAddressView, self).setUp()
+
+    def test_requires_login(self):
+        response = self.get(reverse('checkout:shipping-address'), user=None)
+        self.assertIsRedirect(response)
+
+    def test_submitting_valid_form_adds_data_to_session(self):
+        self.add_product_to_basket()
+        page = self.get(reverse('checkout:shipping-address'))
+        form = page.forms['new_shipping_address']
+        form['first_name'] = 'Barry'
+        form['last_name'] = 'Chuckle'
+        form['line1'] = '1 King Street'
+        form['line4'] = 'Gotham City'
+        form['postcode'] = 'N1 7RR'
+        response = form.submit()
+        self.assertRedirectUrlName(response, 'checkout:shipping-method')
+
+        session_data = self.app.session['checkout_data']
+        session_fields = session_data['shipping']['new_address_fields']
+        self.assertEqual(u'Barry', session_fields['first_name'])
+        self.assertEqual(u'Chuckle', session_fields['last_name'])
+        self.assertEqual(u'1 King Street', session_fields['line1'])
+        self.assertEqual(u'Gotham City', session_fields['line4'])
+        self.assertEqual(u'N1 7RR', session_fields['postcode'])
+
+
+class TestShippingMethodView(CheckoutMixin, WebTestCase):
+
+    def test_requires_login(self):
+        response = self.get(reverse('checkout:shipping-method'), user=None)
+        self.assertIsRedirect(response)
+
+    def test_redirects_when_only_one_shipping_method(self):
+        self.add_product_to_basket()
+        self.enter_shipping_address()
+        response = self.get(reverse('checkout:shipping-method'))
+        self.assertRedirectUrlName(response, 'checkout:payment-method')
+
+
+class TestPreviewView(CheckoutMixin, WebTestCase):
+
+    def test_allows_order_to_be_placed(self):
+        self.add_product_to_basket()
+        self.enter_shipping_address()
+
+        payment_details = self.get(
+            reverse('checkout:shipping-method')).follow().follow()
+        preview = payment_details.click(linkid="view_preview")
+        preview.forms['place-order-form'].submit().follow()
+
+        self.assertEqual(1, Order.objects.all().count())
+
+
+class TestPlacingAnOrderUsingAVoucher(CheckoutMixin, WebTestCase):
+
+    def test_records_use(self):
+        self.add_product_to_basket()
+        self.add_voucher_to_basket()
+        self.enter_shipping_address()
+        thankyou = self.place_order()
+
+        order = thankyou.context['order']
+        self.assertEqual(1, order.discounts.all().count())
+
+        discount = order.discounts.all()[0]
+        voucher = discount.voucher
+        self.assertEqual(1, voucher.num_orders)
+
+
+class TestPlacingAnOrderUsingAnOffer(CheckoutMixin, WebTestCase):
+
+    def test_records_use(self):
+        offer = factories.create_offer()
+        self.add_product_to_basket()
+        self.enter_shipping_address()
+        self.place_order()
+
+        # Reload offer
+        offer = ConditionalOffer.objects.get(id=offer.id)
+
+        self.assertEqual(1, offer.num_orders)
+        self.assertEqual(1, offer.num_applications)

tests/functional/checkout/guest_checkout_tests.py

@@ -1,4 +1,3 @@
-from decimal import Decimal as D
 import sys
 
 from django.test.utils import override_settings
@@ -7,9 +6,9 @@ from django.conf import settings
 from django.utils.importlib import import_module
 import mock
 
-from oscar.apps.address.models import Country
 from oscar.test.testcases import WebTestCase
 from oscar.test import factories
+from . import CheckoutMixin
 
 # Python 3 compat
 try:
@@ -25,43 +24,6 @@ def reload_url_conf():
     import_module(settings.ROOT_URLCONF)
 
 
-class CheckoutMixin(object):
-
-    def create_digital_product(self):
-        product = factories.create_product(price=D('12.00'), num_in_stock=None)
-        product.product_class.requires_shipping = False
-        product.product_class.track_stock = False
-        product.product_class.save()
-        return product
-
-    def add_product_to_basket(self, product=None):
-        if product is None:
-            product = factories.create_product(price=D('12.00'),
-                                               num_in_stock=10)
-        detail_page = self.get(product.get_absolute_url())
-        form = detail_page.forms['add_to_basket_form']
-        form.submit()
-
-    def enter_guest_details(self, email='guest@example.com'):
-        index_page = self.get(reverse('checkout:index'))
-        index_page.form['username'] = email
-        index_page.form.submit()
-
-    def enter_shipping_address(self):
-        Country.objects.get_or_create(
-            iso_3166_1_a2='GB', is_shipping_country=True)
-        address_page = self.get(reverse('checkout:shipping-address'))
-        form = address_page.forms['new_shipping_address']
-        form['first_name'] = 'John'
-        form['last_name'] = 'Doe'
-        form['line1'] = '1 Egg Road'
-        form['line4'] = 'Shell City'
-        form['postcode'] = 'N12 9RT'
-        form.submit()
-
-    def enter_shipping_method(self):
-        self.get(reverse('checkout:shipping-method'))
-
 @override_settings(OSCAR_ALLOW_ANON_CHECKOUT=True)
 class TestIndexView(CheckoutMixin, WebTestCase):
     is_anonymous = True