Don't use django.template.Context for template rendering

Since Django 1.11 dicts should be passed to template rendering functions

src/oscar/apps/customer/abstract_models.py

@@ -6,7 +6,7 @@ from django.contrib.auth import models as auth_models
 from django.core.urlresolvers import reverse
 from django.core.validators import RegexValidator
 from django.db import models
-from django.template import Context, Template, TemplateDoesNotExist
+from django.template import Template, TemplateDoesNotExist
 from django.template.loader import get_template
 from django.utils import six, timezone
 from django.utils.encoding import python_2_unicode_compatible
@@ -244,8 +244,9 @@ class AbstractCommunicationEventType(models.Model):
             settings, 'OSCAR_STATIC_BASE_URL', None)
 
         messages = {}
+        ctx = {}
         for name, template in templates.items():
-            messages[name] = template.render(Context(ctx)) if template else ''
+            messages[name] = template.render(ctx) if template else ''
 
         # Ensure the email subject doesn't contain any newlines
         messages['subject'] = messages['subject'].replace("\n", "")

src/oscar/apps/customer/alerts/utils.py

@@ -4,7 +4,7 @@ from django.conf import settings
 from django.contrib.sites.models import Site
 from django.core import mail
 from django.db.models import Max
-from django.template import Context, loader
+from django.template import loader
 
 from oscar.apps.customer.notifications import services
 from oscar.core.loading import get_class, get_model
@@ -32,10 +32,10 @@ def send_alert_confirmation(alert):
     """
     Send an alert confirmation email.
     """
-    ctx = Context({
+    ctx = {
         'alert': alert,
         'site': Site.objects.get_current(),
-    })
+    }
     subject_tpl = loader.get_template('customer/alerts/emails/'
                                       'confirmation_subject.txt')
     body_tpl = loader.get_template('customer/alerts/emails/'
@@ -93,11 +93,11 @@ def send_product_alerts(product):
         if not data.availability.is_available_to_buy:
             continue
 
-        ctx = Context({
+        ctx = {
             'alert': alert,
             'site': Site.objects.get_current(),
             'hurry': hurry_mode,
-        })
+        }
         if alert.user:
             # Send a site notification
             num_notifications += 1

src/oscar/forms/widgets.py

@@ -4,7 +4,6 @@ from django import forms
 from django.core.files.uploadedfile import InMemoryUploadedFile
 from django.forms.utils import flatatt
 from django.forms.widgets import FileInput
-from django.template import Context
 from django.template.loader import render_to_string
 from django.utils import formats, six
 from django.utils.encoding import force_text
@@ -42,11 +41,11 @@ class ImageInput(FileInput):
             image_url = final_attrs['value'] = force_text(
                 self._format_value(value))
 
-        return render_to_string(self.template_name, Context({
+        return render_to_string(self.template_name, {
             'input_attrs': flatatt(final_attrs),
             'image_url': image_url,
             'image_id': "%s-image" % final_attrs['id'],
-        }))
+        })
 
 
 class WYSIWYGTextArea(forms.Textarea):

src/oscar/templatetags/product_tags.py

@@ -23,6 +23,8 @@ def render_product(context, product):
              % product.get_product_class().slug,
              'catalogue/partials/product.html']
     template_ = select_template(names)
+    context = context.flatten()
+
     # Ensure the passed product is in the context as 'product'
     context['product'] = product
     return template_.render(context)

tests/integration/test_settings.py

@@ -1,5 +1,5 @@
 from django.test import TestCase
-from django.template import loader, Context, TemplateDoesNotExist
+from django.template import loader, TemplateDoesNotExist
 
 import oscar
 
@@ -39,11 +39,11 @@ class TestOscarTemplateSettings(TestCase):
     def test_allows_a_template_to_be_customized(self):
         path = 'base.html'
         template = loader.get_template(path)
-        rendered_template = template.render(Context())
+        rendered_template = template.render({})
         self.assertIn('Oscar Test Shop', rendered_template)
 
     def test_default_oscar_templates_are_accessible(self):
         path = 'oscar/base.html'
         template = loader.get_template(path)
-        rendered_template = template.render(Context())
+        rendered_template = template.render({})
         self.assertNotIn('Oscar Test Shop', rendered_template)