Use settings to control pagination_by values

docs/source/internals/contributing/running-tests.rst

@@ -29,7 +29,6 @@ You can also run tests which match an expression via::
 
     $ ./runtests.py tests/unit/offer/availability_tests.py -k is_unavailable
 
-
 Testing against different setups
 --------------------------------
 

src/oscar/apps/catalogue/reviews/views.py

@@ -1,10 +1,10 @@
 from django.shortcuts import get_object_or_404, redirect
 from django.views.generic import ListView, DetailView, CreateView, View
 from django.contrib import messages
-from oscar.core.loading import get_model
 from django.utils.translation import ugettext_lazy as _
+from django.conf import settings
 
-from oscar.core.loading import get_classes
+from oscar.core.loading import get_model, get_classes
 from oscar.core.utils import redirect_to_referrer
 from oscar.apps.catalogue.reviews.signals import review_added
 
@@ -110,7 +110,7 @@ class ProductReviewList(ListView):
     context_object_name = "reviews"
     model = ProductReview
     product_model = Product
-    paginate_by = 20
+    paginate_by = settings.OSCAR_REVIEWS_PER_PAGE
 
     def get_queryset(self):
         qs = self.model.approved.filter(product=self.kwargs['product_pk'])

src/oscar/apps/customer/notifications/views.py

@@ -3,6 +3,7 @@ from django.utils.translation import ugettext_lazy as _, ungettext
 from django.utils.timezone import now
 from django.contrib import messages
 from django.views import generic
+from django.conf import settings
 
 from oscar.core.loading import get_model
 from oscar.core.utils import redirect_to_referrer
@@ -16,7 +17,7 @@ class NotificationListView(PageTitleMixin, generic.ListView):
     model = Notification
     template_name = 'customer/notifications/list.html'
     context_object_name = 'notifications'
-    paginate_by = 20
+    paginate_by = settings.OSCAR_NOTIFICATIONS_PER_PAGE
     page_title = _("Notifications")
     active_tab = 'notifications'
 

src/oscar/apps/customer/views.py

@@ -399,7 +399,7 @@ class ChangePasswordView(PageTitleMixin, generic.FormView):
 class EmailHistoryView(PageTitleMixin, generic.ListView):
     context_object_name = "emails"
     template_name = 'customer/email/email_list.html'
-    paginate_by = 20
+    paginate_by = settings.OSCAR_EMAILS_PER_PAGE
     page_title = _('Email History')
     active_tab = 'emails'
 
@@ -432,7 +432,7 @@ class OrderHistoryView(PageTitleMixin, generic.ListView):
     """
     context_object_name = "orders"
     template_name = 'customer/order/order_list.html'
-    paginate_by = 20
+    paginate_by = settings.OSCAR_ORDERS_PER_PAGE
     model = Order
     form_class = OrderSearchForm
     page_title = _('Order History')
@@ -612,7 +612,7 @@ class AddressListView(PageTitleMixin, generic.ListView):
     """Customer address book"""
     context_object_name = "addresses"
     template_name = 'customer/address/address_list.html'
-    paginate_by = 40
+    paginate_by = settings.OSCAR_ADDRESSES_PER_PAGE
     active_tab = 'addresses'
     page_title = _('Address Book')
 

src/oscar/apps/dashboard/catalogue/views.py

@@ -6,6 +6,7 @@ from django.core.urlresolvers import reverse
 from django.utils.translation import ugettext_lazy as _
 from django.shortcuts import get_object_or_404, redirect
 from django.template.loader import render_to_string
+from django.conf import settings
 
 from oscar.core.loading import get_classes, get_model
 
@@ -495,7 +496,7 @@ class StockAlertListView(generic.ListView):
     template_name = 'dashboard/catalogue/stockalert_list.html'
     model = StockAlert
     context_object_name = 'alerts'
-    paginate_by = 20
+    paginate_by = settings.OSCAR_STOCK_ALERTS_PER_PAGE
 
     def get_context_data(self, **kwargs):
         ctx = super(StockAlertListView, self).get_context_data(**kwargs)

src/oscar/apps/dashboard/orders/views.py

@@ -114,7 +114,7 @@ class OrderListView(BulkEditMixin, ListView):
     context_object_name = 'orders'
     template_name = 'dashboard/orders/order_list.html'
     form_class = OrderSearchForm
-    paginate_by = 25
+    paginate_by = settings.OSCAR_DASHBOARD_ITEMS_PER_PAGE
     actions = ('download_selected_orders', 'change_order_statuses')
 
     def dispatch(self, request, *args, **kwargs):

src/oscar/apps/dashboard/pages/views.py

@@ -1,14 +1,14 @@
 from django.contrib import messages
 from django.core.exceptions import ValidationError
 from django.core.urlresolvers import reverse
-from oscar.core.loading import get_model
 from django.http import HttpResponseRedirect
 from django.template.loader import render_to_string
 from django.utils.translation import ugettext_lazy as _
 from django.views import generic
-
 from django.views.generic import ListView
+from django.conf import settings
 
+from oscar.core.loading import get_model
 from oscar.core.utils import slugify
 from oscar.core.validators import URLDoesNotExistValidator
 from oscar.apps.dashboard.pages import forms
@@ -25,7 +25,7 @@ class PageListView(ListView):
     template_name = 'dashboard/pages/index.html'
     model = FlatPage
     form_class = forms.PageSearchForm
-    paginate_by = 25
+    paginate_by = settings.OSCAR_DASHBOARD_ITEMS_PER_PAGE
     desc_template = u'%(main_filter)s %(title_filter)s'
 
     def get_queryset(self):

src/oscar/apps/dashboard/reports/views.py

@@ -2,6 +2,7 @@ from django.http import HttpResponseForbidden, Http404
 from django.template.response import TemplateResponse
 from django.views.generic import ListView
 from django.utils.translation import ugettext_lazy as _
+from django.conf import settings
 
 from oscar.core.loading import get_class
 ReportForm = get_class('dashboard.reports.forms', 'ReportForm')
@@ -11,7 +12,7 @@ GeneratorRepository = get_class('dashboard.reports.utils',
 
 class IndexView(ListView):
     template_name = 'dashboard/reports/index.html'
-    paginate_by = 25
+    paginate_by = settings.OSCAR_DASHBOARD_ITEMS_PER_PAGE
     context_object_name = 'objects'
     report_form_class = ReportForm
     generator_repository = GeneratorRepository

src/oscar/apps/dashboard/reviews/views.py

@@ -1,6 +1,7 @@
 import datetime
 
 from django.views import generic
+from django.conf import settings
 from django.db.models import Q
 from django.utils.translation import ugettext_lazy as _
 from django.core.urlresolvers import reverse
@@ -21,7 +22,7 @@ class ReviewListView(BulkEditMixin, generic.ListView):
     context_object_name = 'review_list'
     form_class = forms.ProductReviewSearchForm
     review_form_class = forms.DashboardProductReviewForm
-    paginate_by = 25
+    paginate_by = settings.OSCAR_DASHBOARD_ITEMS_PER_PAGE
     actions = ('update_selected_review_status',)
     checkbox_object_name = 'review'
     desc_template = _("%(main_filter)s %(date_filter)s %(status_filter)s"

src/oscar/apps/dashboard/users/views.py

@@ -1,4 +1,5 @@
 from django.db.models import Q
+from django.conf import settings
 from django.contrib import messages
 from django.shortcuts import redirect
 from django.utils.translation import ugettext_lazy as _
@@ -157,7 +158,7 @@ class ProductAlertListView(ListView):
     form_class = ProductAlertSearchForm
     context_object_name = 'alerts'
     template_name = 'dashboard/users/alerts/list.html'
-    paginate_by = 20
+    paginate_by = settings.OSCAR_DASHBOARD_ITEMS_PER_PAGE
     base_description = _('All Alerts')
     description = ''
 

src/oscar/apps/dashboard/vouchers/views.py

@@ -1,5 +1,6 @@
 import datetime
 
+from django.conf import settings
 from django.contrib import messages
 from django.core.urlresolvers import reverse
 from oscar.core.loading import get_model
@@ -25,7 +26,7 @@ class VoucherListView(generic.ListView):
     template_name = 'dashboard/vouchers/voucher_list.html'
     form_class = VoucherSearchForm
     description_template = _("%(main_filter)s %(name_filter)s %(code_filter)s")
-    paginate_by = 25
+    paginate_by = settings.OSCAR_DASHBOARD_ITEMS_PER_PAGE
 
     def get_queryset(self):
         qs = self.model.objects.all().order_by('-date_created')

src/oscar/defaults.py

@@ -35,11 +35,17 @@ OSCAR_UPLOAD_ROOT = '/tmp'
 OSCAR_REQUIRED_ADDRESS_FIELDS = ('first_name', 'last_name', 'line1',
                                  'line4', 'postcode', 'country')
 
-# Offer list settings
-OSCAR_OFFERS_PER_PAGE = 20
+# Pagination settings
 
-# Product list settings
+OSCAR_OFFERS_PER_PAGE = 20
 OSCAR_PRODUCTS_PER_PAGE = 20
+OSCAR_REVIEWS_PER_PAGE = 20
+OSCAR_NOTIFICATIONS_PER_PAGE = 20
+OSCAR_EMAILS_PER_PAGE = 20
+OSCAR_ORDERS_PER_PAGE = 20
+OSCAR_ADDRESSES_PER_PAGE = 20
+OSCAR_STOCK_ALERTS_PER_PAGE = 20
+OSCAR_DASHBOARD_ITEMS_PER_PAGE = 20
 
 # Checkout
 OSCAR_ALLOW_ANON_CHECKOUT = False