Bump flake8 from 4.0.1 to 6.0.0 (#4021)

* Bump flake8 from 4.0.1 to 6.0.0

Bumps [flake8](https://github.com/pycqa/flake8) from 4.0.1 to 6.0.0.
- [Release notes](https://github.com/pycqa/flake8/releases)
- [Commits](https://github.com/pycqa/flake8/compare/4.0.1...6.0.0)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fixes pyflakes errors

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lars van de Kerkhof <lars@permanentmarkers.nl>

requirements.txt

@@ -17,7 +17,7 @@ uWSGI>=2.0.19,<2.1
 whitenoise>=5.2,<6.5
 
 # Linting
-flake8==4.0.1
+flake8==6.0.0
 flake8-debugger==4.1.2
 isort==5.10.1
 

src/oscar/apps/dashboard/orders/forms.py

@@ -99,7 +99,7 @@ class OrderSearchForm(forms.Form):
         # Ensure that 'response_format' is always set
         if 'data' in kwargs:
             data = kwargs['data']
-            del(kwargs['data'])
+            del kwargs['data']
         elif len(args) > 0:
             data = args[0]
             args = args[1:]

src/oscar/test/factories/order.py

@@ -99,9 +99,9 @@ class OrderLineFactory(factory.django.DjangoModelFactory):
     order = factory.SubFactory(OrderFactory)
     product = factory.SubFactory(
         'oscar.test.factories.ProductFactory')
-    partner_sku = factory.LazyAttribute(lambda l: l.product.upc)
+    partner_sku = factory.LazyAttribute(lambda x: x.product.upc)
     stockrecord = factory.LazyAttribute(
-        lambda l: l.product.stockrecords.first())
+        lambda s: s.product.stockrecords.first())
     quantity = 1
 
     line_price_incl_tax = factory.LazyAttribute(lambda obj: tax_add(obj.stockrecord.price) * obj.quantity)

tests/functional/dashboard/test_review.py

@@ -28,7 +28,7 @@ class ReviewsDashboardTests(WebTestCase):
         ProductReviewFactory(pk=2, user=user2, status=0)
         ProductReviewFactory(pk=3, user=user2, status=0)
 
-        assert(ProductReview.objects.count() == 3)
+        assert ProductReview.objects.count() == 3
 
         list_page = self.get(reverse('dashboard:reviews-list'))
         form = list_page.forms[1]