Bug AbsoluteDiscountBenefit (#3954)

* fix bug AbsoluteDiscountBenefit. Now discount is applied to all product and not one time on the basket only

* Revert "fix bug AbsoluteDiscountBenefit. Now discount is applied to all product and not one time on the basket only"

This reverts commit afae2c7ded.

* fix :wrench: update description for existing absolute discount

* feat :star: add migration file for absolute benefit description

* Revert "feat :star: add migration file for absolute benefit description"

This reverts commit 896c381f25.

* fix :wrench: edit existing migration file for absolute discount benefit

---------

Co-authored-by: Samar Hassan <samarhassanphone@gmail.com>

src/oscar/apps/offer/abstract_models.py

@@ -550,7 +550,7 @@ class AbstractBenefit(BaseOfferMixin, models.Model):
     )
     TYPE_CHOICES = (
         (PERCENTAGE, _("Discount is a percentage off of the product's value")),
-        (FIXED, _("Discount is a fixed amount off of the product's value")),
+        (FIXED, _("Discount is a fixed amount off of the basket's total")),
         (MULTIBUY, _("Discount is to give the cheapest product for free")),
         (FIXED_PRICE, _("Get the products that meet the condition for a fixed price")),
         (SHIPPING_ABSOLUTE, _("Discount is a fixed amount of the shipping cost")),

src/oscar/apps/offer/migrations/0001_initial.py

@@ -24,7 +24,7 @@ class Migration(migrations.Migration):
             name='Benefit',
             fields=[
                 ('id', models_AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
-                ('type', models.CharField(verbose_name='Type', max_length=128, blank=True, choices=[('Percentage', "Discount is a percentage off of the product's value"), ('Absolute', "Discount is a fixed amount off of the product's value"), ('Multibuy', 'Discount is to give the cheapest product for free'), ('Fixed price', 'Get the products that meet the condition for a fixed price'), ('Shipping absolute', 'Discount is a fixed amount of the shipping cost'), ('Shipping fixed price', 'Get shipping for a fixed price'), ('Shipping percentage', 'Discount is a percentage off of the shipping cost')])),
+                ('type', models.CharField(verbose_name='Type', max_length=128, blank=True, choices=[('Percentage', "Discount is a percentage off of the product's value"), ('Absolute', "Discount is a fixed amount off of the basket's total"), ('Multibuy', 'Discount is to give the cheapest product for free'), ('Fixed price', 'Get the products that meet the condition for a fixed price'), ('Shipping absolute', 'Discount is a fixed amount of the shipping cost'), ('Shipping fixed price', 'Get shipping for a fixed price'), ('Shipping percentage', 'Discount is a percentage off of the shipping cost')])),
                 ('value', oscar.models.fields.PositiveDecimalField(max_digits=12, decimal_places=2, blank=True, verbose_name='Value', null=True)),
                 ('max_affected_items', models.PositiveIntegerField(verbose_name='Max Affected Items', blank=True, help_text='Set this to prevent the discount consuming all items within the range that are in the basket.', null=True)),
                 ('proxy_class', oscar.models.fields.NullCharField(unique=True, verbose_name='Custom class', default=None, max_length=255)),