Merge pull request #1816 from binarydud/fix/missing_promotions_form_field

Fix missing page_url promotions form field

src/oscar/apps/dashboard/promotions/forms.py

@@ -75,7 +75,7 @@ class PagePromotionForm(forms.ModelForm):
 
     class Meta:
         model = PagePromotion
-        fields = ['position']
+        fields = ['position', 'page_url']
 
     def clean_page_url(self):
         page_url = self.cleaned_data.get('page_url')

tests/unit/dashboard/promotions_form_tests.py

@@ -0,0 +1,19 @@
+from django.test import TestCase
+
+from oscar.apps.dashboard.promotions import forms
+from oscar.core.loading import get_classes
+
+RawHTML, PagePromotion = get_classes('promotions.models', ['RawHTML', 'PagePromotion'])
+
+
+class TestPagePromotionForm(TestCase):
+
+    def test_page_promotion_has_fields(self):
+        promotion = RawHTML()
+        promotion.save()
+        instance = PagePromotion(content_object=promotion)
+        data = {'position': 'page', 'page_url': '/'}
+        form = forms.PagePromotionForm(data=data, instance=instance)
+        self.assertTrue(form.is_valid())
+        page_promotion = form.save()
+        self.assertEqual(page_promotion.page_url, '/')