Browse Source

Ensure testing deps don't clobber package ones

Installing the requirements.txt after running 'setup.py develop' can
cause problems as it doesn't respect the version ranges from setup.py.
This was picked up by Hudson which was installing Django==1.5 when
upgrading django-nose.

This is addresses by:

* Adding Django to requirements.txt
* Running 'setup.py develop' AFTER installing requirements.txt
master
David Winterbottom 13 years ago
parent
commit
b91b9e892b
2 changed files with 6 additions and 2 deletions
  1. 2
    2
      Makefile
  2. 4
    0
      requirements.txt

+ 2
- 2
Makefile View File

@@ -2,12 +2,12 @@
2 2
 .PHONY: contribute ci test i18n lint travis
3 3
 
4 4
 install:
5
-	python setup.py develop
6 5
 	pip install -r requirements.txt --use-mirrors
6
+	python setup.py develop
7 7
 
8 8
 upgrade:
9
-	python setup.py develop --upgrade
10 9
 	pip install --upgrade -r requirements.txt --use-mirrors
10
+	python setup.py develop --upgrade
11 11
 
12 12
 sandbox: install
13 13
 	-rm -f sites/sandbox/db.sqlite

+ 4
- 0
requirements.txt View File

@@ -13,6 +13,10 @@ Sphinx>=1.1.3,<1.2
13 13
 django-dynamic-fixture>=1.6.4,<1.7
14 14
 mock>=1.0.1,<1.1
15 15
 coverage>=3.6,<3.7
16
+# We specify Django here as CI installs these requirements with the --upgrade
17
+# option which will ignore the Django requirements from setup.py and possibly
18
+# bump it to an unsupported version.  Django-nose install Django.
19
+django<1.5
16 20
 django-nose>=1.1,<1.2
17 21
 nose<1.2
18 22
 # Use a slightly older version of nose-progressive to play nicely

Loading…
Cancel
Save