Преглед изворни кода

Merge pull request #3550 from jwayodi/fix/report-generator-date-range-filter-field-lookups

Fix field lookups in ReportGenerator.filter_with_date_range
master
Samir Shah пре 5 година
родитељ
комит
c15b7e0951
No account linked to committer's email address
1 измењених фајлова са 5 додато и 14 уклоњено
  1. 5
    14
      src/oscar/apps/dashboard/reports/reports.py

+ 5
- 14
src/oscar/apps/dashboard/reports/reports.py Прегледај датотеку

1
-from datetime import datetime, time
1
+from datetime import time
2
 
2
 
3
 from django.http import HttpResponse
3
 from django.http import HttpResponse
4
 from django.template.defaultfilters import date
4
 from django.template.defaultfilters import date
5
-from django.utils import timezone
6
 from django.utils.translation import gettext_lazy as _
5
 from django.utils.translation import gettext_lazy as _
7
 
6
 
8
 from oscar.core import utils
7
 from oscar.core import utils
74
 
73
 
75
         # After the start date
74
         # After the start date
76
         if self.start_date:
75
         if self.start_date:
77
-            start_datetime = timezone.make_aware(
78
-                datetime.combine(self.start_date, time(0, 0)),
79
-                timezone.get_default_timezone())
80
-
76
+            start_datetime = utils.datetime_combine(self.start_date, time.min)
81
             filter_kwargs = {
77
             filter_kwargs = {
82
-                "%s__gt" % self.date_range_field_name: start_datetime,
78
+                "%s__gte" % self.date_range_field_name: start_datetime,
83
             }
79
             }
84
             queryset = queryset.filter(**filter_kwargs)
80
             queryset = queryset.filter(**filter_kwargs)
85
 
81
 
86
         # Before the end of the end date
82
         # Before the end of the end date
87
         if self.end_date:
83
         if self.end_date:
88
-            end_of_end_date = datetime.combine(
89
-                self.end_date,
90
-                time(hour=23, minute=59, second=59)
91
-            )
92
-            end_datetime = timezone.make_aware(end_of_end_date,
93
-                                               timezone.get_default_timezone())
84
+            end_datetime = utils.datetime_combine(self.end_date, time.max)
94
             filter_kwargs = {
85
             filter_kwargs = {
95
-                "%s__lt" % self.date_range_field_name: end_datetime,
86
+                "%s__lte" % self.date_range_field_name: end_datetime,
96
             }
87
             }
97
             queryset = queryset.filter(**filter_kwargs)
88
             queryset = queryset.filter(**filter_kwargs)
98
 
89
 

Loading…
Откажи
Сачувај