Tided up download options on dashboard order list page.

This can still be extended easily, but is now prettier for single option
downloads which is the default.

oscar/apps/dashboard/orders/app.py

@@ -5,7 +5,7 @@ from oscar.core.application import Application
 from oscar.apps.dashboard.orders import views
 from oscar.apps.dashboard.nav import register, Node
 
-node = Node('Manage orders')
+node = Node('Orders')
 node.add_child(Node('Orders', 'dashboard:order-list'))
 node.add_child(Node('Statistics', 'dashboard:order-summary'))
 register(node)

oscar/apps/dashboard/orders/views.py

@@ -181,9 +181,12 @@ class OrderListView(ListView, BulkEditMixin):
             return self.download_selected_orders(self.request, context['object_list'])
         return super(OrderListView, self).render_to_response(context)
 
+    def get_download_filename(self, request):
+        return 'orders.csv'
+
     def download_selected_orders(self, request, orders):
         response = HttpResponse(mimetype='text/csv')
-        response['Content-Disposition'] = 'attachment; filename=orders.csv'
+        response['Content-Disposition'] = 'attachment; filename=%s' % self.get_download_filename(request)
         writer = csv.writer(response, delimiter=',')
 
         meta_data = (('number', 'Order number'),

oscar/apps/dashboard/views.py

@@ -6,6 +6,11 @@ from django.http import HttpResponseRedirect
 
 
 class BulkEditMixin():
+    """
+    Mixin for views that have a bulk editing facility.  This is normally in the
+    form of tabular data where each row has a checkbox.  The UI allows a number
+    of rows to be selected and then some 'action' to be performed on them.
+    """
     actions = None
     current_view = None
     checkbox_object_name = None
@@ -20,13 +25,16 @@ class BulkEditMixin():
             return None
 
     def post(self, request, *args, **kwargs):
+        # Dynamic dispatch patter - we forward POST requests onto a method
+        # designated by the 'action' parameter.  The action has to be in a
+        # whitelist to avoid security issues.
         action = request.POST.get('action', '').lower()
         if not self.actions or action not in self.actions:
             messages.error(self.request, "Invalid action")
             return HttpResponseRedirect(reverse(self.current_view))
         ids = request.POST.getlist('selected_%s' % self.get_checkbox_object_name())
         if not ids:
-            messages.error(self.request, "You need to select some %s" % self.get_checkbox_object_name())
+            messages.error(self.request, "You need to select some %ss" % self.get_checkbox_object_name())
             return HttpResponseRedirect(reverse(self.current_view))
 
         raw_objects = self.model.objects.in_bulk(ids)

oscar/templates/dashboard/orders/order_list.html

@@ -78,12 +78,6 @@ Order management | {{ block.super }}
 {% if orders.count %}
 <form action="." method="post" class="order_table">
     {% csrf_token %}
-    <div class="well well-danger">
-        <h3 class="app-ico ico_logout icon">Download</h3>
-        <label>With selected orders: Download as CSV </label>
-        <input type="radio" name="action" value="download_selected_orders" /> 
-        <button type="submit" class="btn btn-primary">Download</button>
-    </div>
 <table class="table table-striped table-bordered">
     <tr>
         <th></th>
@@ -115,6 +109,13 @@ Order management | {{ block.super }}
     {% endfor %}
 </table>
 
+<div class="well well-danger">
+	<h3 class="app-ico ico_logout icon">Download</h3>
+	<label>Download selected orders as a CSV</label>
+	<input type="hidden" name="action" value="download_selected_orders" />
+	<button type="submit" class="btn btn-primary">Download</button>
+</div>
+
 {% if page_obj %}
     {% include "catalogue/partials/pagination.html" %}
 {% endif %}