Split voucher testcase for better coherence

tests/unit/voucher_tests.py

@@ -13,35 +13,40 @@ START_DATE = datetime.date(2011, 01, 01)
 END_DATE = datetime.date(2012, 01, 01)
 
 
-class TestVoucher(TestCase):
+class TestSavingAVoucher(TestCase):
 
     def test_saves_code_as_uppercase(self):
-        voucher = Voucher.objects.create(code='lower',
-                                         start_date=START_DATE,
-                                         end_date=END_DATE)
+        voucher = Voucher(code='lower', start_date=START_DATE,
+                          end_date=END_DATE)
+        voucher.save()
         self.assertEqual('LOWER', voucher.code)
 
-    def test_checks_dates_are_sensible(self):
+    def test_verifies_dates_are_sensible(self):
         with self.assertRaises(exceptions.ValidationError):
             voucher = Voucher.objects.create(code='lower',
                                             start_date=END_DATE,
                                             end_date=START_DATE)
             voucher.clean()
 
+
+class TestAVoucher(TestCase):
+
+    def setUp(self):
+        self.voucher = Voucher(start_date=START_DATE, end_date=END_DATE)
+
     def test_is_active_between_start_and_end_dates(self):
-        test = datetime.date(2011, 01, 10)
-        voucher = Voucher(start_date=START_DATE, end_date=END_DATE)
-        self.assertTrue(voucher.is_active(test))
+        test = datetime.date(2011, 06, 10)
+        self.assertTrue(self.voucher.is_active(test))
 
     def test_is_active_on_end_date(self):
-        test = END_DATE
-        voucher = Voucher(start_date=START_DATE, end_date=END_DATE)
-        self.assertTrue(voucher.is_active(test))
+        self.assertTrue(self.voucher.is_active(END_DATE))
+
+    def test_is_active_on_start_date(self):
+        self.assertTrue(self.voucher.is_active(START_DATE))
 
     def test_is_inactive_outside_of_start_and_end_dates(self):
         test = datetime.date(2012, 03, 10)
-        voucher = Voucher(start_date=START_DATE, end_date=END_DATE)
-        self.assertFalse(voucher.is_active(test))
+        self.assertFalse(self.voucher.is_active(test))
 
     def test_increments_total_discount_when_recording_usage(self):
         voucher = G(Voucher)