Stopped treating checkout:index as a special case.

This view has a form that assumes anon checkout is allowed, which it
isn't always.  Treating it as a special case was causing it to be
displayed when it shouldn't.

oscar/apps/checkout/app.py

@@ -10,7 +10,7 @@ from oscar.apps.checkout.views import IndexView, ShippingAddressView, UserAddres
 
 class CheckoutApplication(Application):
     name = 'checkout'
-    
+
     index_view = IndexView
     shipping_address_view = ShippingAddressView
     user_address_create_view = UserAddressCreateView
@@ -40,8 +40,6 @@ class CheckoutApplication(Application):
         return self.post_process_urls(urlpatterns)
 
     def get_url_decorator(self, pattern):
-        if pattern.name == 'index':
-            return None
         if not settings.OSCAR_ALLOW_ANON_CHECKOUT:
             return login_required
         if pattern.name.startswith('user-address'):

sandbox/settings.py

@@ -247,7 +247,7 @@ from oscar.defaults import *
 
 
 OSCAR_RECENTLY_VIEWED_PRODUCTS = 20
-OSCAR_ALLOW_ANON_CHECKOUT = True
+OSCAR_ALLOW_ANON_CHECKOUT = False
 OSCAR_INITIAL_ORDER_STATUS = 'Pending'
 OSCAR_INITIAL_LINE_STATUS = 'Pending'
 OSCAR_ORDER_STATUS_PIPELINE = {

tests/functional/checkout_tests.py

@@ -55,10 +55,10 @@ class CheckoutMixin(object):
 class DisabledAnonymousCheckoutViewsTests(ClientTestCase):
     is_anonymous = True
 
-    def test_index_does_not_require_login(self):
+    def test_index_does_require_login(self):
         url = reverse('checkout:index')
         response = self.client.get(url)
-        self.assertIsOk(response)
+        self.assertIsRedirect(response)
 
     def test_user_address_views_require_a_login(self):
         urls = [reverse('checkout:user-address-create'),
@@ -118,7 +118,7 @@ class TestShippingAddressView(ClientTestCase, CheckoutMixin):
         self.add_product_to_basket()
         response = self.client.get(reverse('checkout:shipping-address'))
         self.assertIsOk(response)
-    
+
     def test_anon_checkout_disabled_by_default(self):
         self.assertFalse(settings.OSCAR_ALLOW_ANON_CHECKOUT)
 
@@ -163,13 +163,13 @@ class TestShippingMethodView(ClientTestCase, CheckoutMixin):
 class TestPaymentMethodView(ClientTestCase, CheckoutMixin):
 
     def test_view_redirects_if_no_shipping_address(self):
-        self.add_product_to_basket() 
+        self.add_product_to_basket()
         response = self.client.get(reverse('checkout:payment-method'))
         self.assertIsRedirect(response)
         self.assertRedirectUrlName(response, 'checkout:shipping-address')
 
     def test_view_redirects_if_no_shipping_method(self):
-        self.add_product_to_basket() 
+        self.add_product_to_basket()
         self.complete_shipping_address()
         response = self.client.get(reverse('checkout:payment-method'))
         self.assertIsRedirect(response)
@@ -253,7 +253,7 @@ class TestOrderPlacement(ClientTestCase, CheckoutMixin):
         self.assertIsRedirect(self.response)
         orders = Order.objects.all()
         self.assertEqual(1, len(orders))
-        
+
 
 class TestPlacingOrderUsingAVoucher(ClientTestCase, CheckoutMixin):