Extend docs on application instances and customising them
Understanding the application tree these days is only necessary when
wanting to change URLs or views. Hence, it's been moved from the
customising doc and reworked into the how-to. This reduced some
considerable duplication and hopefully makes the customisation section
clearer.
Docs: Remove how-tos on customising mixins and overriding core class
These days, to override a mixin it is only required to override the
OrderPlacementMixin; overriding the app and view is not necessary. It is
just a generic case of overriding a core class. A dedicated how-to is
thus unnecessary.
As overriding a core class is the general goal of any advanced
customisation, it has been merged into the customisation section, which
has been given an overhaul as well.
The section regarding modifying apps will be re-added as part of a
higher-level "the Oscar application tree" kind of document.
The getting started guide now explicitly mentions copying the "missing
image" image when working with a remote file storage. Was raised in
issue #1314.
[Backport] Docs: Fix formatting of command line instructions
Sphinx turned the double dash into a long dash. A user reported issues
with running the command after copy&pasting it.
(cherry picked from commit 90ab1f19f0)
Oscar is slowly adding better support for switching languages on the
fly. That also means that locales need to be switched.
The issue this commit tries to fix is that when switching languages, the
locale for rendering prices doesn't change, and hence prices are
formatted incorrectly.
Oscar used to require hardcoding the locale for prices via
OSCAR_CURRENCY_LOCALE. I'm not sure what the reasoning behind this was,
because as far as I'm aware, the locale can be auto-detected from the
current language. This not only reduces complexity, but nicely works
when switching languages.
Several of Oscar dependencies don't support Windows, some of them don't
work at all. Added a warning that indicates installing Oscar on Windows
is a tricky process.
This allows importing a class or attribute by the reasonably common
string notation, which is useful for e.g. settings. When using settings,
we should prefer absolute imports over using get_class, because that
limits us to modules in INSTALLED_APPS.
Make proxy_class fields NullCharFields to avoid uniqueness issues
Django has issues with using blank=True and unique=True together on a
CharField, which is why we've introduced the NullCharField. A more
detailed description can be found in it's docstring.
The same problems apply to the proxy_class fields on offer models.
Switching them to NullCharFields should resolve the problem.
Also altered one check for proxy_class to be consistent with the other
checks for an empty proxy class.
Non-critical migration for CommunicationEventType.code
A check for outstanding migrations brought this up. Unfortunately I
can't find a way to instruct South to ignore the parameter. Model
introspection only allows setting what basically is fancy default
values. Parameters like help_text are ignored in South's
USELESS_PATTERNS, but can't be altered.
* Made upper_limit a DecimalField, like the other weight fields
* Increased default precision for weights to be to the gram level. Will
be useful for deployments shipping smaller items such as stickers,
where 10 grams precision is too low.
* Changed strings to official 'kg' abbreviation.
Rename and move Scales class, and make it overridable
Making it overridable allows altering the weighing method of the basket,
which I wanted to do in a project. As get_classes doesn't support
importing from top-level products, it had to be moved to a scales
module.
Other class names tend to use singular, so as the imports had to be
changed anyway, Scales was renamed to Scale.
Remove useless entropy-increasing calls of django.conf.urls.patterns
The function essentially does two things:
1. it applies a prefix - the first argument - to the given urls. In no
instance a prefix was given
2. it calls url() for simple tuple or list elements in the given iterable.
Cases where such a tuple or list was passed to patterns have been
replaced by direct calls to url()
2 allowed for both calls to url() and simple tuples to be listed in
get_urls() and similar places. This allowed for unnecessary variation.
Always calling url() makes the url lists look less noisy and more uniform,
allowing the reader to focus on the actual differences of the urls instead
of superfluities.
django.conf.urls.patterns will also undergo deprecation starting from
Django 1.8. This commit anticipates that change.
https://docs.djangoproject.com/en/dev/releases/1.8/#django-conf-urls-patterns
Changing a unofficially deprecated model name is clearer than having
three places to get at the same model.
The name 'AbstractBase' is consistent both with our naming of other
abstract models, and lots of apps having a Base class.
This is a common and useful Oscar pattern, and there's no reason to not
use it for the shipping app.
They are not imported anywhere in Oscar and just provided for
convenience, so no imports had to be altered.
[Backport] Allow unassigning categories from products
This has been impossible so far. It is easily achieved by setting
can_delete=True on the formset.
I spent some time trying to get the nice solution working, which would
be that assigning an empty category means deleting that ProductCategory
instance. But I haven't found a good solution that avoids problems like
in #1267. I have since come to the conclusion that enabling can_delete
is the right thing to do. One can then explicitly hide the checkbox,
but set the correct hidden field in Javascript on the client side if
an empty value is assigned.
The fields section has been moved from the factory declaration to the
ProductForm Meta class to allow for easier customisation.
Fixes #1289
(cherry picked from commit 3e4c2f73dd)
This has been impossible so far. It is easily achieved by setting
can_delete=True on the formset.
I spent some time trying to get the nice solution working, which would
be that assigning an empty category means deleting that ProductCategory
instance. But I haven't found a good solution that avoids problems like
in #1267. I have since come to the conclusion that enabling can_delete
is the right thing to do. One can then explicitly hide the checkbox,
but set the correct hidden field in Javascript on the client side if
an empty value is assigned.
The fields section has been moved from the factory declaration to the
ProductForm Meta class to allow for easier customisation.
Fixes #1289
Extend tracker pixel to include Python and Django version
Reasoning about e.g. when it is feasible to drop Python 2.6 or Django
1.5 support is hard without reliable data, hence the tracker pixel has
been extended to submit the Python and Django version in use. Tracking
is still easily disabled by setting OSCAR_TRACKING to False.
This Javascript plugin was used to style browser scrollbars in a
cross-platform way. I belief it's better to remove it:
a) It doesn't do anything, at least on my Ubuntu Chrome nor Firefox.
b) I'm sure there's decent reasons why there isn't a cross-platform
way to style scrollbars. It's a liability when it comes to smartphones
and tables, because those scrollbars use a different UI.
c) It's easy to add back again if so desired.
Add support for i18n_patterns and enable for sandbox
This required:
* Moving Django's i18n urls into the main urls.py and outside of the
scope of Oscar's main application class, because they need to live
outside of the scope of i18n_patterns
* Add a language-code stripped version of the current URL to the
template context to get the language switcher working.
I also updated the language switcher code to mimic what is currently
given as an example in Django's docs.
Fixes #797
David Winterbottom
Dmitry Voronin
Maik Hoepfel
Moayad Mardini
Markus Bertheau
Wu Jiang