The priority isn't strictly a "restriction", but this seems like the most sensible form to add it to.

Notification subjects have a max length of 255 characters, which can easily be exceeded by long product names. Change the alert logic to provide a short notification subject and put the longer content in the notification body.

This patch also modifies the notification utils to make it obvious that the positional argument is a notification subject, not a body.

This is to prevent the possibility of spamming a user by generating lots of alert confirmation emails for product alerts.

Also allow unconfirmed alerts to be cancelled - we send a cancellation link in the confirmation email, so we should let users cancel an alert if they don't want to confirm it.

Fixes #2401.

Better to use filenames which are commonly used in the python word then
custom ones.

Latter one is deprecated

A dict_values object was returned instead of a list. See #2223

Future tasks is to dig into self.assertRedirectsTo wouldn't work with the test
as it stands

This provides a minimal login template to access the dashboard. This is
especially useful when the shop doesn't provide accounts.

See #1474

These tests will fail without this PR fix.

Replace 'assert' with 'assert*' method.

Convert tests.unit.forms.widget_tests to use TestCase class.

Convert bankcard tests to use TestCase.

Convert tests.unit.logging_tests to use TestCase.

Create a factory module per app and move them under the new
oscar.test.factories module.

The test belongs to the other functional dashboard order tests

This also removes the attr() marking of tests. This can be implemented
in pytest with marking the tests with a custom marker if required.

The `create_test_category_tree` doesn’t assert anything and is already tested via the integration tests.

Adds new functional tests for ShippingAddressView, PaymentDetailsView
and ThankYouView.
It's the second part of #1645.

Notes

* Adds a custom template to be able to test some functionalities of
  PaymentDetailsView
* Adds an helper to the CheckoutMixin

That approach is around from sometime around Oscar 0.6. With the
category refactor, it has become expensive to support. I doubt it has
any SEO impact, as e.g. Amazon has product IDs etc. all over their URLs.
@mbertheau seconded this opinion.

When we stopped storing the concatenated slugs on each category,
generating the URL for an individual category got more expensive. But
luckily it is safe to naively cache it, as the matching view only
considers the primary key any way. So even a stale cache should lead to
the right category.

This commit makes them ever so slightly more readable.

As category slugs are relevant for SEO, it is often desirable to be able
to change them independently of the name.
Previously, Oscar by default updated the slug on each save().

This commit completely removes the logic to update an existing slug, as
it is an anti-pattern, as it breaks old links to the site.

It also doesn't raise a ValidationError in the save() method any more,
which is an anti pattern as well. Unfortunately, we can't validate
uniqueness in a clean_slug method (where it should live) as we need
treebeard's information about siblings, which is only available after
save.

This commit replaces the previous slug handling by a simpler approach:
if no slug is supplied, we generate one -- otherwise we assume the user
knows what they're doing.

* Uses factory-boy factories
* Adds helpers to the CheckoutMixin helper
* Adds plenty of functional tests
* Adds HTML IDs to some forms to be able to easily reference them
  from our tests

@maikhoepfel:
This commit is the squashed version of #1645, but it
does not contain the template changes. The unused
ShippingAddressView code was already cherry-picked across in 549decb.

I also fixed some PEP8 issues.

We have two methods doing something very similiar, so I'm removing the
one with the worse name.

Thanks go to @itbabu for spotting it in
https://github.com/django-oscar/django-oscar/pull/1645#issuecomment-71896876

06c2441 changed the way actions are submitted for on the dashboard's
order list view. This commit updates the test to match the new
behaviour.

I'd also argue that the two test methods test different aspects of the
same thing, so I merged them, which saves us one (relatively slow) test
run.