Docs: Remove another mention of South for migrations
I found some docs changes in my git stash that seemed useful. We removed
support for support when removing Django 1.6 support, so we can remove
mention of South.
Transactions were improved with Django 1.6; the atomic decorator was
added at the same time. We could've removed this helper earlier, but
better late than never.
Unify to (basket, user=None, request=None) argument order in Applicator
This order offers the simplest API for common needs - as evidenced by the
fact that the apply_offers crook could be removed from two test files,
saving on imports as well.
Deprecate accessing categories without primary key
That approach is around from sometime around Oscar 0.6. With the
category refactor, it has become expensive to support. I doubt it has
any SEO impact, as e.g. Amazon has product IDs etc. all over their URLs.
@mbertheau seconded this opinion.
Previously, all views handled in Oscar's Application class were
decorated with the permissions_required decorator. That decorator would
not do anything if used with an empty set of permissions, but it
nonetheless seems cleaner to not decorate the views in the first place.
Raised in:
https://github.com/django-oscar/django-oscar-api/pull/2/files#r23832083
Unfortunately, I completely missed the host argument to is_safe_url.
Without it, the check will have always returned False (see #1557).
This change fixes this behaviour. Unfortunately, it does require
changing the notation of the safe_referrer and redirect_to_referrer
utility functions.
They are from a time when we had one stockrecord per product, and no
strategy classes. They're used for visual purposes only, and were
forgotten when the codebase was updated. They failed loudly, as reported
in #1592.
We really need to either drop them or add a helper method to the
strategy class, but to ensure backwards-compatibility, I've
re-implemented the naive approach of just sorting by price; blindly
ignoring the many shortcomings.
I also added a deprecation notice.
[Forwardport] Fix bug with __all__ creation in partner app
A simple typo lead to star imports not working as expected. As it's
easily worked around, we won't issue a release right away.
Closes #1553.
(cherry picked from commit 80babf2c19)
Conflicts:
docs/source/releases/index.rst
Oscar is in production at major companies, and has proven itself in all
kinds of scenarios. It's time the version number acknowledges that.
This means there never will be a 0.8 final release; only betas were
released as 0.8 version.
This commit removes a few long deprecated bits in the docs and in
code. It also updates the
release notes to include those removals, and highlights what has been
deprecated in 0.8. And it fixes a Sphinx warning when building the docs.
Changes include:
- New section on organisation
- General moving round of sections, especially around backwards
incompatibilities
- Various copy changes
Explicitly pass the billing address around checkout
This changeset adjusts `build_submission` to include the billing address.
This also requires changes to a few method signatures to handle the
billing address explicitly.
This only works when the billing address is stored in the session (as
that's where it is looked up from when building the submission data in
`build_submission`). In many cases (such as Oscar's demo site), we don't
store the billing address in the session - instead, it is captured via
the payment-details forms. Hence, the billing address will still need to
be explicitly set within the submission data.
Fixes #1508