You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

form_tests.py 6.5KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177
  1. from decimal import Decimal as D
  2. from django.test import TestCase
  3. from django.conf import settings
  4. import mock
  5. from oscar.apps.basket import forms
  6. from oscar.apps.offer.utils import Applicator
  7. from oscar.core.loading import get_model
  8. from oscar.test import factories
  9. from oscar.test.basket import add_product
  10. from oscar.test.factories import (
  11. BenefitFactory, ConditionalOfferFactory, ConditionFactory, RangeFactory)
  12. Line = get_model('basket', 'Line')
  13. class TestBasketLineForm(TestCase):
  14. def setUp(self):
  15. self.applicator = Applicator()
  16. rng = RangeFactory(includes_all_products=True)
  17. self.condition = ConditionFactory(
  18. range=rng, type=ConditionFactory._meta.model.VALUE,
  19. value=D('100'), proxy_class=None)
  20. self.benefit = BenefitFactory(
  21. range=rng, type=BenefitFactory._meta.model.FIXED,
  22. value=D('10'), max_affected_items=1)
  23. self.basket = factories.create_basket()
  24. self.line = self.basket.all_lines()[0]
  25. def mock_availability_return_value(self, is_available, reason=''):
  26. policy = self.line.purchase_info.availability
  27. policy.is_purchase_permitted = mock.MagicMock(
  28. return_value=(is_available, reason))
  29. def build_form(self, quantity=None):
  30. if quantity is None:
  31. quantity = self.line.quantity
  32. return forms.BasketLineForm(
  33. strategy=self.basket.strategy,
  34. data={'quantity': quantity},
  35. instance=self.line)
  36. def test_enforces_availability_policy_for_valid_quantities(self):
  37. self.mock_availability_return_value(True)
  38. form = self.build_form()
  39. self.assertTrue(form.is_valid())
  40. def test_enforces_availability_policy_for_invalid_quantities(self):
  41. self.mock_availability_return_value(False, "Some reason")
  42. form = self.build_form()
  43. self.assertFalse(form.is_valid())
  44. self.assertEqual(
  45. form.errors['quantity'], ['Some reason'])
  46. def test_skips_availability_policy_for_zero_quantities(self):
  47. self.mock_availability_return_value(True)
  48. form = self.build_form(quantity=0)
  49. self.assertTrue(form.is_valid())
  50. def test_enforces_max_line_quantity_for_new_product(self):
  51. invalid_qty = settings.OSCAR_MAX_BASKET_QUANTITY_THRESHOLD + 1
  52. form = self.build_form(quantity=invalid_qty)
  53. self.assertFalse(form.is_valid())
  54. def test_enforce_max_line_quantity_for_existing_product(self):
  55. settings.OSCAR_MAX_BASKET_QUANTITY_THRESHOLD = 10
  56. self.basket.flush()
  57. product = factories.create_product(num_in_stock=20)
  58. add_product(self.basket, D('100'), 4, product)
  59. self.line = self.basket.all_lines()[0]
  60. form = self.build_form(quantity=6)
  61. self.assertTrue(form.is_valid())
  62. form.save()
  63. form = self.build_form(quantity=11)
  64. self.assertFalse(form.is_valid())
  65. def test_basketline_formset_ordering(self):
  66. # when we use a unordered queryset in the Basketlineformset, the
  67. # discounts will be lost because django will query the database
  68. # again to enforce ordered results
  69. add_product(self.basket, D('100'), 5)
  70. offer = ConditionalOfferFactory(
  71. pk=1, condition=self.condition, benefit=self.benefit)
  72. # now we force an unordered queryset so we can see that our discounts
  73. # will disappear due to a new ordering query (see django/forms/model.py)
  74. default_line_ordering = Line._meta.ordering
  75. Line._meta.ordering = []
  76. self.basket._lines = self.basket.lines.all()
  77. self.applicator.apply_offers(self.basket, [offer])
  78. formset = forms.BasketLineFormSet(
  79. strategy=self.basket.strategy,
  80. queryset=self.basket.all_lines())
  81. # the discount is in all_lines():
  82. self.assertTrue(self.basket.all_lines()[0].has_discount)
  83. # but not in the formset
  84. self.assertFalse(formset.forms[0].instance.has_discount)
  85. # Restore the ordering on the line
  86. Line._meta.ordering = default_line_ordering
  87. # clear the cached lines and apply the offer again
  88. self.basket._lines = None
  89. self.applicator.apply_offers(self.basket, [offer])
  90. formset = forms.BasketLineFormSet(
  91. strategy=self.basket.strategy,
  92. queryset=self.basket.all_lines())
  93. self.assertTrue(formset.forms[0].instance.has_discount)
  94. class TestAddToBasketForm(TestCase):
  95. def test_allows_a_product_quantity_to_be_increased(self):
  96. basket = factories.create_basket()
  97. product = basket.all_lines()[0].product
  98. # Add more of the same product
  99. data = {'quantity': 1}
  100. form = forms.AddToBasketForm(
  101. basket=basket, product=product, data=data)
  102. self.assertTrue(form.is_valid())
  103. def test_checks_whether_passed_product_id_matches_a_real_product(self):
  104. basket = factories.create_basket()
  105. product = basket.all_lines()[0].product
  106. # Add more of the same product
  107. data = {'quantity': -1}
  108. form = forms.AddToBasketForm(
  109. basket=basket, product=product, data=data)
  110. self.assertFalse(form.is_valid())
  111. def test_checks_if_purchase_is_permitted(self):
  112. basket = factories.BasketFactory()
  113. product = factories.ProductFactory()
  114. # Build a 4-level mock monster so we can force the return value of
  115. # whether the product is available to buy. This is a serious code smell
  116. # and needs to be remedied.
  117. info = mock.Mock()
  118. info.availability = mock.Mock()
  119. info.availability.is_purchase_permitted = mock.Mock(
  120. return_value=(False, "Not on your nelly!"))
  121. basket.strategy.fetch_for_product = mock.Mock(
  122. return_value=info)
  123. data = {'quantity': 1}
  124. form = forms.AddToBasketForm(
  125. basket=basket, product=product, data=data)
  126. self.assertFalse(form.is_valid())
  127. self.assertEqual('Not on your nelly!', form.errors['__all__'][0])
  128. def test_mixed_currency_baskets_are_not_permitted(self):
  129. # Ensure basket is one currency
  130. basket = mock.Mock()
  131. basket.currency = 'GBP'
  132. basket.num_items = 1
  133. # Ensure new product has different currency
  134. info = mock.Mock()
  135. info.price.currency = 'EUR'
  136. basket.strategy.fetch_for_product = mock.Mock(
  137. return_value=info)
  138. product = factories.ProductFactory()
  139. data = {'quantity': 1}
  140. form = forms.AddToBasketForm(
  141. basket=basket, product=product, data=data)
  142. self.assertFalse(form.is_valid())