You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

test_forms.py 13KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339
  1. from decimal import Decimal as D
  2. from unittest import mock
  3. from django.conf import settings
  4. from django.test import TestCase, override_settings
  5. from oscar.apps.basket import forms, formsets
  6. from oscar.apps.offer.utils import Applicator
  7. from oscar.core.loading import get_model
  8. from oscar.test import factories
  9. from oscar.test.basket import add_product
  10. from oscar.test.factories import (
  11. AttributeOptionFactory, AttributeOptionGroupFactory, BenefitFactory,
  12. ConditionalOfferFactory, ConditionFactory, OptionFactory, RangeFactory)
  13. Line = get_model('basket', 'Line')
  14. Option = get_model('catalogue', 'Option')
  15. class TestBasketLineForm(TestCase):
  16. def setUp(self):
  17. self.applicator = Applicator()
  18. rng = RangeFactory(includes_all_products=True)
  19. self.condition = ConditionFactory(
  20. range=rng, type=ConditionFactory._meta.model.VALUE,
  21. value=D('100'), proxy_class=None)
  22. self.benefit = BenefitFactory(
  23. range=rng, type=BenefitFactory._meta.model.FIXED,
  24. value=D('10'), max_affected_items=1)
  25. self.basket = factories.create_basket()
  26. self.line = self.basket.all_lines()[0]
  27. def mock_availability_return_value(self, is_available, reason=''):
  28. policy = self.line.purchase_info.availability
  29. policy.is_purchase_permitted = mock.MagicMock(
  30. return_value=(is_available, reason))
  31. def build_form(self, quantity=None):
  32. if quantity is None:
  33. quantity = self.line.quantity
  34. return forms.BasketLineForm(
  35. strategy=self.basket.strategy,
  36. data={'quantity': quantity},
  37. instance=self.line)
  38. def test_interpret_empty_quantity_field_as_zero(self):
  39. form = self.build_form(quantity="")
  40. self.assertTrue(form.is_valid())
  41. self.assertEqual(form.cleaned_data['quantity'], 0)
  42. def test_enforces_availability_policy_for_valid_quantities(self):
  43. self.mock_availability_return_value(True)
  44. form = self.build_form()
  45. self.assertTrue(form.is_valid())
  46. def test_enforces_availability_policy_for_invalid_quantities(self):
  47. self.mock_availability_return_value(False, "Some reason")
  48. form = self.build_form()
  49. self.assertFalse(form.is_valid())
  50. self.assertEqual(
  51. form.errors['quantity'], ['Some reason'])
  52. def test_skips_availability_policy_for_zero_quantities(self):
  53. self.mock_availability_return_value(True)
  54. form = self.build_form(quantity=0)
  55. self.assertTrue(form.is_valid())
  56. def test_enforces_max_line_quantity_for_new_product(self):
  57. invalid_qty = settings.OSCAR_MAX_BASKET_QUANTITY_THRESHOLD + 1
  58. form = self.build_form(quantity=invalid_qty)
  59. self.assertFalse(form.is_valid())
  60. @override_settings(OSCAR_MAX_BASKET_QUANTITY_THRESHOLD=10)
  61. def test_enforce_max_line_quantity_for_existing_product(self):
  62. self.basket.flush()
  63. product = factories.create_product(num_in_stock=20)
  64. add_product(self.basket, D('100'), 4, product)
  65. self.line = self.basket.all_lines()[0]
  66. form = self.build_form(quantity=6)
  67. self.assertTrue(form.is_valid())
  68. form.save()
  69. form = self.build_form(quantity=11)
  70. self.assertFalse(form.is_valid())
  71. def test_line_quantity_max_attribute_per_num_available(self):
  72. self.basket.flush()
  73. product = factories.create_product(num_in_stock=20)
  74. add_product(self.basket, D('100'), 4, product)
  75. self.line = self.basket.all_lines()[0]
  76. form = self.build_form()
  77. self.assertIn('max="20"', str(form['quantity']))
  78. @override_settings(OSCAR_MAX_BASKET_QUANTITY_THRESHOLD=10)
  79. def test_line_quantity_max_attribute_per_basket_threshold(self):
  80. self.basket.flush()
  81. product = factories.create_product(num_in_stock=20)
  82. add_product(self.basket, D('100'), 4, product)
  83. self.line = self.basket.all_lines()[0]
  84. form = self.build_form()
  85. self.assertIn('max="6"', str(form['quantity']))
  86. def test_basketline_formset_ordering(self):
  87. # when we use a unordered queryset in the Basketlineformset, the
  88. # discounts will be lost because django will query the database
  89. # again to enforce ordered results
  90. add_product(self.basket, D('100'), 5)
  91. offer = ConditionalOfferFactory(
  92. pk=1, condition=self.condition, benefit=self.benefit)
  93. # now we force an unordered queryset so we can see that our discounts
  94. # will disappear due to a new ordering query (see django/forms/model.py)
  95. default_line_ordering = Line._meta.ordering
  96. Line._meta.ordering = []
  97. self.basket._lines = self.basket.lines.all()
  98. self.applicator.apply_offers(self.basket, [offer])
  99. formset = formsets.BasketLineFormSet(
  100. strategy=self.basket.strategy,
  101. queryset=self.basket.all_lines())
  102. # the discount is in all_lines():
  103. self.assertTrue(self.basket.all_lines()[0].has_discount)
  104. # but not in the formset
  105. self.assertFalse(formset.forms[0].instance.has_discount)
  106. # Restore the ordering on the line
  107. Line._meta.ordering = default_line_ordering
  108. # clear the cached lines and apply the offer again
  109. self.basket._lines = None
  110. self.applicator.apply_offers(self.basket, [offer])
  111. formset = formsets.BasketLineFormSet(
  112. strategy=self.basket.strategy,
  113. queryset=self.basket.all_lines())
  114. self.assertTrue(formset.forms[0].instance.has_discount)
  115. def test_max_allowed_quantity_with_options(self):
  116. self.basket.flush()
  117. option = OptionFactory(required=False)
  118. product = factories.create_product(num_in_stock=2)
  119. product.get_product_class().options.add(option)
  120. self.basket.add_product(product, options=[{"option": option, "value": "Test 1"}])
  121. self.basket.add_product(product, options=[{"option": option, "value": "Test 2"}])
  122. form = forms.BasketLineForm(
  123. strategy=self.basket.strategy,
  124. data={'quantity': 2},
  125. instance=self.basket.all_lines()[0]
  126. )
  127. self.assertFalse(form.is_valid())
  128. self.assertIn(
  129. "Available stock is only %s, which has been exceeded because multiple lines contain the same product." % 2,
  130. str(form.errors)
  131. )
  132. class TestAddToBasketForm(TestCase):
  133. def test_allows_a_product_quantity_to_be_increased(self):
  134. basket = factories.create_basket()
  135. product = basket.all_lines()[0].product
  136. # Add more of the same product
  137. data = {'quantity': 1}
  138. form = forms.AddToBasketForm(
  139. basket=basket, product=product, data=data)
  140. self.assertTrue(form.is_valid())
  141. def test_checks_whether_passed_product_id_matches_a_real_product(self):
  142. basket = factories.create_basket()
  143. product = basket.all_lines()[0].product
  144. # Add more of the same product
  145. data = {'quantity': -1}
  146. form = forms.AddToBasketForm(
  147. basket=basket, product=product, data=data)
  148. self.assertFalse(form.is_valid())
  149. def test_checks_if_purchase_is_permitted(self):
  150. basket = factories.BasketFactory()
  151. product = factories.ProductFactory()
  152. # Build a 4-level mock monster so we can force the return value of
  153. # whether the product is available to buy. This is a serious code smell
  154. # and needs to be remedied.
  155. info = mock.Mock()
  156. info.availability = mock.Mock()
  157. info.availability.is_purchase_permitted = mock.Mock(
  158. return_value=(False, "Not on your nelly!"))
  159. basket.strategy.fetch_for_product = mock.Mock(
  160. return_value=info)
  161. data = {'quantity': 1}
  162. form = forms.AddToBasketForm(
  163. basket=basket, product=product, data=data)
  164. self.assertFalse(form.is_valid())
  165. self.assertEqual('Not on your nelly!', form.errors['__all__'][0])
  166. def test_mixed_currency_baskets_are_not_permitted(self):
  167. # Ensure basket is one currency
  168. basket = mock.Mock()
  169. basket.currency = 'GBP'
  170. basket.num_items = 1
  171. # Ensure new product has different currency
  172. info = mock.Mock()
  173. info.price.currency = 'EUR'
  174. basket.strategy.fetch_for_product = mock.Mock(
  175. return_value=info)
  176. product = factories.ProductFactory()
  177. data = {'quantity': 1}
  178. form = forms.AddToBasketForm(
  179. basket=basket, product=product, data=data)
  180. self.assertFalse(form.is_valid())
  181. def test_cannot_add_a_product_without_price(self):
  182. basket = factories.BasketFactory()
  183. product = factories.create_product(price=None)
  184. data = {'quantity': 1}
  185. form = forms.AddToBasketForm(
  186. basket=basket, product=product, data=data)
  187. self.assertFalse(form.is_valid())
  188. self.assertEqual(
  189. form.errors['__all__'][0],
  190. 'This product cannot be added to the basket because a price '
  191. 'could not be determined for it.',
  192. )
  193. class TestAddToBasketWithOptionForm(TestCase):
  194. def setUp(self):
  195. self.basket = factories.create_basket(empty=True)
  196. self.product = factories.create_product(num_in_stock=1)
  197. def _get_basket_form(self, basket, product, data=None):
  198. return forms.AddToBasketForm(basket=basket, product=product, data=data)
  199. def test_basket_option_field_exists(self):
  200. option = OptionFactory()
  201. self.product.product_class.options.add(option)
  202. form = self._get_basket_form(basket=self.basket, product=self.product)
  203. self.assertIn(option.code, form.fields)
  204. def test_add_to_basket_with_not_required_option(self):
  205. option = OptionFactory(required=False)
  206. self.product.product_class.options.add(option)
  207. data = {'quantity': 1}
  208. form = self._get_basket_form(
  209. basket=self.basket, product=self.product, data=data,
  210. )
  211. self.assertTrue(form.is_valid())
  212. self.assertFalse(form.fields[option.code].required)
  213. def test_add_to_basket_with_required_option(self):
  214. option = OptionFactory(required=True)
  215. self.product.product_class.options.add(option)
  216. data = {'quantity': 1}
  217. invalid_form = self._get_basket_form(
  218. basket=self.basket, product=self.product, data=data,
  219. )
  220. self.assertFalse(invalid_form.is_valid())
  221. self.assertTrue(invalid_form.fields[option.code].required)
  222. data[option.code] = 'Test value'
  223. valid_form = self._get_basket_form(
  224. basket=self.basket, product=self.product, data=data,
  225. )
  226. self.assertTrue(valid_form.is_valid())
  227. def _test_add_to_basket_with_specific_option_type(
  228. self, option_type, invalid_value, valid_value
  229. ):
  230. if option_type in [Option.SELECT, Option.RADIO, Option.MULTI_SELECT, Option.CHECKBOX]:
  231. group = AttributeOptionGroupFactory(name="minte")
  232. AttributeOptionFactory(option="henk", group=group)
  233. AttributeOptionFactory(option="klaas", group=group)
  234. option = OptionFactory(required=True, type=option_type, option_group=group)
  235. else:
  236. option = OptionFactory(required=True, type=option_type)
  237. self.product.product_class.options.add(option)
  238. data = {'quantity': 1, option.code: invalid_value}
  239. invalid_form = self._get_basket_form(
  240. basket=self.basket, product=self.product, data=data,
  241. )
  242. self.assertFalse(invalid_form.is_valid())
  243. data[option.code] = valid_value
  244. valid_form = self._get_basket_form(
  245. basket=self.basket, product=self.product, data=data,
  246. )
  247. self.assertTrue(valid_form.is_valid())
  248. def test_add_to_basket_with_integer_option(self):
  249. self._test_add_to_basket_with_specific_option_type(
  250. Option.INTEGER, 1.55, 1,
  251. )
  252. def test_add_to_basket_with_float_option(self):
  253. self._test_add_to_basket_with_specific_option_type(
  254. Option.FLOAT, 'invalid_float', 1,
  255. )
  256. def test_add_to_basket_with_bool_option(self):
  257. self._test_add_to_basket_with_specific_option_type(
  258. Option.BOOLEAN, None, True,
  259. )
  260. def test_add_to_basket_with_date_option(self):
  261. self._test_add_to_basket_with_specific_option_type(
  262. Option.DATE, 'invalid_date', '2019-03-03',
  263. )
  264. def test_add_to_basket_with_select_option(self):
  265. self._test_add_to_basket_with_specific_option_type(
  266. Option.SELECT, 'invalid_select', 'henk',
  267. )
  268. def test_add_to_basket_with_radio_option(self):
  269. self._test_add_to_basket_with_specific_option_type(
  270. Option.RADIO, 'invalid_radio', 'henk',
  271. )
  272. def test_add_to_basket_with_multi_select_option(self):
  273. self._test_add_to_basket_with_specific_option_type(
  274. Option.MULTI_SELECT, ['invalid_multi_select'], ['henk', 'klaas'],
  275. )
  276. def test_add_to_basket_with_checkbox_option(self):
  277. self._test_add_to_basket_with_specific_option_type(
  278. Option.CHECKBOX, ['invalid_checkbox'], ['henk', 'klaas'],
  279. )