You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

test_forms.py 11KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286
  1. from decimal import Decimal as D
  2. from unittest import mock
  3. from django.conf import settings
  4. from django.test import TestCase, override_settings
  5. from oscar.apps.basket import forms, formsets
  6. from oscar.apps.offer.utils import Applicator
  7. from oscar.core.loading import get_model
  8. from oscar.test import factories
  9. from oscar.test.basket import add_product
  10. from oscar.test.factories import (
  11. BenefitFactory, ConditionalOfferFactory, ConditionFactory,
  12. OptionFactory, RangeFactory)
  13. Line = get_model('basket', 'Line')
  14. Option = get_model('catalogue', 'Option')
  15. class TestBasketLineForm(TestCase):
  16. def setUp(self):
  17. self.applicator = Applicator()
  18. rng = RangeFactory(includes_all_products=True)
  19. self.condition = ConditionFactory(
  20. range=rng, type=ConditionFactory._meta.model.VALUE,
  21. value=D('100'), proxy_class=None)
  22. self.benefit = BenefitFactory(
  23. range=rng, type=BenefitFactory._meta.model.FIXED,
  24. value=D('10'), max_affected_items=1)
  25. self.basket = factories.create_basket()
  26. self.line = self.basket.all_lines()[0]
  27. def mock_availability_return_value(self, is_available, reason=''):
  28. policy = self.line.purchase_info.availability
  29. policy.is_purchase_permitted = mock.MagicMock(
  30. return_value=(is_available, reason))
  31. def build_form(self, quantity=None):
  32. if quantity is None:
  33. quantity = self.line.quantity
  34. return forms.BasketLineForm(
  35. strategy=self.basket.strategy,
  36. data={'quantity': quantity},
  37. instance=self.line)
  38. def test_enforces_availability_policy_for_valid_quantities(self):
  39. self.mock_availability_return_value(True)
  40. form = self.build_form()
  41. self.assertTrue(form.is_valid())
  42. def test_enforces_availability_policy_for_invalid_quantities(self):
  43. self.mock_availability_return_value(False, "Some reason")
  44. form = self.build_form()
  45. self.assertFalse(form.is_valid())
  46. self.assertEqual(
  47. form.errors['quantity'], ['Some reason'])
  48. def test_skips_availability_policy_for_zero_quantities(self):
  49. self.mock_availability_return_value(True)
  50. form = self.build_form(quantity=0)
  51. self.assertTrue(form.is_valid())
  52. def test_enforces_max_line_quantity_for_new_product(self):
  53. invalid_qty = settings.OSCAR_MAX_BASKET_QUANTITY_THRESHOLD + 1
  54. form = self.build_form(quantity=invalid_qty)
  55. self.assertFalse(form.is_valid())
  56. @override_settings(OSCAR_MAX_BASKET_QUANTITY_THRESHOLD=10)
  57. def test_enforce_max_line_quantity_for_existing_product(self):
  58. self.basket.flush()
  59. product = factories.create_product(num_in_stock=20)
  60. add_product(self.basket, D('100'), 4, product)
  61. self.line = self.basket.all_lines()[0]
  62. form = self.build_form(quantity=6)
  63. self.assertTrue(form.is_valid())
  64. form.save()
  65. form = self.build_form(quantity=11)
  66. self.assertFalse(form.is_valid())
  67. def test_line_quantity_max_attribute_per_num_available(self):
  68. self.basket.flush()
  69. product = factories.create_product(num_in_stock=20)
  70. add_product(self.basket, D('100'), 4, product)
  71. self.line = self.basket.all_lines()[0]
  72. form = self.build_form()
  73. self.assertIn('max="20"', str(form['quantity']))
  74. @override_settings(OSCAR_MAX_BASKET_QUANTITY_THRESHOLD=10)
  75. def test_line_quantity_max_attribute_per_basket_threshold(self):
  76. self.basket.flush()
  77. product = factories.create_product(num_in_stock=20)
  78. add_product(self.basket, D('100'), 4, product)
  79. self.line = self.basket.all_lines()[0]
  80. form = self.build_form()
  81. self.assertIn('max="6"', str(form['quantity']))
  82. def test_basketline_formset_ordering(self):
  83. # when we use a unordered queryset in the Basketlineformset, the
  84. # discounts will be lost because django will query the database
  85. # again to enforce ordered results
  86. add_product(self.basket, D('100'), 5)
  87. offer = ConditionalOfferFactory(
  88. pk=1, condition=self.condition, benefit=self.benefit)
  89. # now we force an unordered queryset so we can see that our discounts
  90. # will disappear due to a new ordering query (see django/forms/model.py)
  91. default_line_ordering = Line._meta.ordering
  92. Line._meta.ordering = []
  93. self.basket._lines = self.basket.lines.all()
  94. self.applicator.apply_offers(self.basket, [offer])
  95. formset = formsets.BasketLineFormSet(
  96. strategy=self.basket.strategy,
  97. queryset=self.basket.all_lines())
  98. # the discount is in all_lines():
  99. self.assertTrue(self.basket.all_lines()[0].has_discount)
  100. # but not in the formset
  101. self.assertFalse(formset.forms[0].instance.has_discount)
  102. # Restore the ordering on the line
  103. Line._meta.ordering = default_line_ordering
  104. # clear the cached lines and apply the offer again
  105. self.basket._lines = None
  106. self.applicator.apply_offers(self.basket, [offer])
  107. formset = formsets.BasketLineFormSet(
  108. strategy=self.basket.strategy,
  109. queryset=self.basket.all_lines())
  110. self.assertTrue(formset.forms[0].instance.has_discount)
  111. class TestAddToBasketForm(TestCase):
  112. def test_allows_a_product_quantity_to_be_increased(self):
  113. basket = factories.create_basket()
  114. product = basket.all_lines()[0].product
  115. # Add more of the same product
  116. data = {'quantity': 1}
  117. form = forms.AddToBasketForm(
  118. basket=basket, product=product, data=data)
  119. self.assertTrue(form.is_valid())
  120. def test_checks_whether_passed_product_id_matches_a_real_product(self):
  121. basket = factories.create_basket()
  122. product = basket.all_lines()[0].product
  123. # Add more of the same product
  124. data = {'quantity': -1}
  125. form = forms.AddToBasketForm(
  126. basket=basket, product=product, data=data)
  127. self.assertFalse(form.is_valid())
  128. def test_checks_if_purchase_is_permitted(self):
  129. basket = factories.BasketFactory()
  130. product = factories.ProductFactory()
  131. # Build a 4-level mock monster so we can force the return value of
  132. # whether the product is available to buy. This is a serious code smell
  133. # and needs to be remedied.
  134. info = mock.Mock()
  135. info.availability = mock.Mock()
  136. info.availability.is_purchase_permitted = mock.Mock(
  137. return_value=(False, "Not on your nelly!"))
  138. basket.strategy.fetch_for_product = mock.Mock(
  139. return_value=info)
  140. data = {'quantity': 1}
  141. form = forms.AddToBasketForm(
  142. basket=basket, product=product, data=data)
  143. self.assertFalse(form.is_valid())
  144. self.assertEqual('Not on your nelly!', form.errors['__all__'][0])
  145. def test_mixed_currency_baskets_are_not_permitted(self):
  146. # Ensure basket is one currency
  147. basket = mock.Mock()
  148. basket.currency = 'GBP'
  149. basket.num_items = 1
  150. # Ensure new product has different currency
  151. info = mock.Mock()
  152. info.price.currency = 'EUR'
  153. basket.strategy.fetch_for_product = mock.Mock(
  154. return_value=info)
  155. product = factories.ProductFactory()
  156. data = {'quantity': 1}
  157. form = forms.AddToBasketForm(
  158. basket=basket, product=product, data=data)
  159. self.assertFalse(form.is_valid())
  160. def test_cannot_add_a_product_without_price(self):
  161. basket = factories.BasketFactory()
  162. product = factories.create_product(price=None)
  163. data = {'quantity': 1}
  164. form = forms.AddToBasketForm(
  165. basket=basket, product=product, data=data)
  166. self.assertFalse(form.is_valid())
  167. self.assertEqual(
  168. form.errors['__all__'][0],
  169. 'This product cannot be added to the basket because a price '
  170. 'could not be determined for it.',
  171. )
  172. class TestAddToBasketWithOptionForm(TestCase):
  173. def setUp(self):
  174. self.basket = factories.create_basket(empty=True)
  175. self.product = factories.create_product(num_in_stock=1)
  176. def _get_basket_form(self, basket, product, data=None):
  177. return forms.AddToBasketForm(basket=basket, product=product, data=data)
  178. def test_basket_option_field_exists(self):
  179. option = OptionFactory()
  180. self.product.product_class.options.add(option)
  181. form = self._get_basket_form(basket=self.basket, product=self.product)
  182. self.assertIn(option.code, form.fields)
  183. def test_add_to_basket_with_not_required_option(self):
  184. option = OptionFactory(required=False)
  185. self.product.product_class.options.add(option)
  186. data = {'quantity': 1}
  187. form = self._get_basket_form(
  188. basket=self.basket, product=self.product, data=data,
  189. )
  190. self.assertTrue(form.is_valid())
  191. self.assertFalse(form.fields[option.code].required)
  192. def test_add_to_basket_with_required_option(self):
  193. option = OptionFactory(required=True)
  194. self.product.product_class.options.add(option)
  195. data = {'quantity': 1}
  196. invalid_form = self._get_basket_form(
  197. basket=self.basket, product=self.product, data=data,
  198. )
  199. self.assertFalse(invalid_form.is_valid())
  200. self.assertTrue(invalid_form.fields[option.code].required)
  201. data[option.code] = 'Test value'
  202. valid_form = self._get_basket_form(
  203. basket=self.basket, product=self.product, data=data,
  204. )
  205. self.assertTrue(valid_form.is_valid())
  206. def _test_add_to_basket_with_specific_option_type(
  207. self, option_type, invalid_value, valid_value
  208. ):
  209. option = OptionFactory(required=True, type=option_type)
  210. self.product.product_class.options.add(option)
  211. data = {'quantity': 1, option.code: invalid_value}
  212. invalid_form = self._get_basket_form(
  213. basket=self.basket, product=self.product, data=data,
  214. )
  215. self.assertFalse(invalid_form.is_valid())
  216. data[option.code] = valid_value
  217. valid_form = self._get_basket_form(
  218. basket=self.basket, product=self.product, data=data,
  219. )
  220. self.assertTrue(valid_form.is_valid())
  221. def test_add_to_basket_with_integer_option(self):
  222. self._test_add_to_basket_with_specific_option_type(
  223. Option.INTEGER, 1.55, 1,
  224. )
  225. def test_add_to_basket_with_float_option(self):
  226. self._test_add_to_basket_with_specific_option_type(
  227. Option.FLOAT, 'invalid_float', 1,
  228. )
  229. def test_add_to_basket_with_bool_option(self):
  230. self._test_add_to_basket_with_specific_option_type(
  231. Option.BOOLEAN, None, True,
  232. )
  233. def test_add_to_basket_with_date_option(self):
  234. self._test_add_to_basket_with_specific_option_type(
  235. Option.DATE, 'invalid_date', '2019-03-03',
  236. )