Pārlūkot izejas kodu

Eslint tweaks (#696)

* make eslint styleguide into warnings & drop no-else-return

* reintroduce max-warnings=0

* remove unnecessary eslint line disable

* reintroduce no-else-return rule
vanilla_orig
David Luzar 5 gadus atpakaļ
vecāks
revīzija
b7a6ceba68
Revīzijas autora e-pasta adrese nav piesaistīta nevienam kontam
3 mainītis faili ar 9 papildinājumiem un 11 dzēšanām
  1. 1
    1
      .lintstagedrc.js
  2. 7
    7
      package.json
  3. 1
    3
      src/clipboard.ts

+ 1
- 1
.lintstagedrc.js Parādīt failu

7
 module.exports = {
7
 module.exports = {
8
   "*.{js,ts,tsx}": files => {
8
   "*.{js,ts,tsx}": files => {
9
     return (
9
     return (
10
-      "eslint --fix " + files.filter(file => !cli.isPathIgnored(file)).join(" ")
10
+      "eslint --max-warnings=0 --fix " + files.filter(file => !cli.isPathIgnored(file)).join(" ")
11
     );
11
     );
12
   },
12
   },
13
   "*.{css,scss,json,md,html,yml}": ["prettier --write"],
13
   "*.{css,scss,json,md,html,yml}": ["prettier --write"],

+ 7
- 7
package.json Parādīt failu

39
       "prettier"
39
       "prettier"
40
     ],
40
     ],
41
     "rules": {
41
     "rules": {
42
-      "curly": "error",
42
+      "curly": "warn",
43
       "no-console": [
43
       "no-console": [
44
-        "error",
44
+        "warn",
45
         {
45
         {
46
           "allow": [
46
           "allow": [
47
             "warn",
47
             "warn",
50
           ]
50
           ]
51
         }
51
         }
52
       ],
52
       ],
53
-      "no-else-return": "error",
54
-      "no-useless-return": "error",
53
+      "no-else-return": "warn",
54
+      "no-useless-return": "warn",
55
       "prefer-const": [
55
       "prefer-const": [
56
-        "error",
56
+        "warn",
57
         {
57
         {
58
           "destructuring": "all"
58
           "destructuring": "all"
59
         }
59
         }
60
       ],
60
       ],
61
-      "prefer-template": "error",
62
-      "prettier/prettier": "error"
61
+      "prefer-template": "warn",
62
+      "prettier/prettier": "warn"
63
     }
63
     }
64
   },
64
   },
65
   "homepage": "https://excalidraw.com",
65
   "homepage": "https://excalidraw.com",

+ 1
- 3
src/clipboard.ts Parādīt failu

62
     const text = e.clipboardData?.getData("text/plain").trim();
62
     const text = e.clipboardData?.getData("text/plain").trim();
63
     if (text && !PREFER_APP_CLIPBOARD) {
63
     if (text && !PREFER_APP_CLIPBOARD) {
64
       return { text };
64
       return { text };
65
-      // eslint-disable-next-line no-else-return
66
-    } else {
67
-      return getAppClipboard();
68
     }
65
     }
66
+    return getAppClipboard();
69
   } catch (e) {}
67
   } catch (e) {}
70
 
68
 
71
   return {};
69
   return {};

Notiek ielāde…
Atcelt
Saglabāt