Explorar el Código

fix(external-api): Avoid naming event 'error'

- EventEmmitter treats 'error' as a special case and throws error.
master
hmuresan hace 3 años
padre
commit
00b5ce71e0
Se han modificado 2 ficheros con 2 adiciones y 2 borrados
  1. 1
    1
      modules/API/API.js
  2. 1
    1
      modules/API/external/external_api.js

+ 1
- 1
modules/API/API.js Ver fichero

@@ -1333,7 +1333,7 @@ class API {
1333 1333
      */
1334 1334
     notifyError(error: Object) {
1335 1335
         this._sendEvent({
1336
-            name: 'error',
1336
+            name: 'error-occurred',
1337 1337
             error
1338 1338
         });
1339 1339
     }

+ 1
- 1
modules/API/external/external_api.js Ver fichero

@@ -81,7 +81,7 @@ const events = {
81 81
     'device-list-changed': 'deviceListChanged',
82 82
     'display-name-change': 'displayNameChange',
83 83
     'email-change': 'emailChange',
84
-    'error': 'error',
84
+    'error-occurred': 'errorOccurred',
85 85
     'endpoint-text-message-received': 'endpointTextMessageReceived',
86 86
     'feedback-submitted': 'feedbackSubmitted',
87 87
     'feedback-prompt-displayed': 'feedbackPromptDisplayed',

Loading…
Cancelar
Guardar