Browse Source

android: fix getting permission request results

Now that we have both a Fragment and an Activity there are lifecycle methods
that overlap. If a Fragment requests permission by calling requestPermissions
then the result handler will be called on itself. React Native's permissions
module, however, calls ActivityCompat.requestPermissions on the Activity, thus
we need to handle the results at the Activity level and not at the Fragment
level.
master
Saúl Ibarra Corretgé 6 years ago
parent
commit
15c5a2339b

+ 5
- 0
android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetActivity.java View File

@@ -151,6 +151,11 @@ public class JitsiMeetActivity extends FragmentActivity
151 151
         JitsiMeetActivityDelegate.requestPermissions(this, permissions, requestCode, listener);
152 152
     }
153 153
 
154
+    @Override
155
+    public void onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults) {
156
+        JitsiMeetActivityDelegate.onRequestPermissionsResult(requestCode, permissions, grantResults);
157
+    }
158
+
154 159
     // JitsiMeetViewListener
155 160
     //
156 161
 

+ 0
- 9
android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetFragment.java View File

@@ -81,15 +81,6 @@ public class JitsiMeetFragment extends Fragment {
81 81
         JitsiMeetActivityDelegate.onHostDestroy(getActivity());
82 82
     }
83 83
 
84
-    // https://developer.android.com/reference/android/support/v4/app/ActivityCompat.OnRequestPermissionsResultCallback
85
-    @Override
86
-    public void onRequestPermissionsResult(
87
-            final int requestCode,
88
-            final String[] permissions,
89
-            final int[] grantResults) {
90
-        JitsiMeetActivityDelegate.onRequestPermissionsResult(requestCode, permissions, grantResults);
91
-    }
92
-
93 84
     @Override
94 85
     public void onResume() {
95 86
         super.onResume();

Loading…
Cancel
Save