소스 검색

fix(keyboardshortcut) spacebar release mutes participant (#9434)

* fix(keyboardshortcut) spacebar release mutes participant

* fix(keyboardshortcut) removed extra check
master
Calinteodor 3 년 전
부모
커밋
2a9b3dc1b2
No account linked to committer's email address
1개의 변경된 파일3개의 추가작업 그리고 8개의 파일을 삭제
  1. 3
    8
      modules/keyboardshortcut/keyboardshortcut.js

+ 3
- 8
modules/keyboardshortcut/keyboardshortcut.js 파일 보기

@@ -62,7 +62,6 @@ const _focusedElementsSelector = `:focus:is(${_elementsBlacklist.join(',')})`;
62 62
  * Maps keycode to character, id of popover for given function and function.
63 63
  */
64 64
 const KeyboardShortcut = {
65
-    isPushToTalkActive: false,
66 65
 
67 66
     init() {
68 67
         this._initGlobalShortcuts();
@@ -97,7 +96,6 @@ const KeyboardShortcut = {
97 96
                             PRESSED));
98 97
                         logger.log('Talk shortcut pressed');
99 98
                         APP.conference.muteAudio(false);
100
-                        this.isPushToTalkActive = true;
101 99
                     }
102 100
                 }
103 101
             } else if (this._getKeyboardKey(e).toUpperCase() === 'ESCAPE') {
@@ -232,12 +230,9 @@ const KeyboardShortcut = {
232 230
         // register SPACE shortcut in two steps to insure visibility of help
233 231
         // message
234 232
         this.registerShortcut(' ', null, () => {
235
-            if (this.isPushToTalkActive) {
236
-                sendAnalytics(createShortcutEvent('push.to.talk', RELEASED));
237
-                logger.log('Talk shortcut released');
238
-                APP.conference.muteAudio(true);
239
-                this.isPushToTalkActive = false;
240
-            }
233
+            sendAnalytics(createShortcutEvent('push.to.talk', RELEASED));
234
+            logger.log('Talk shortcut released');
235
+            APP.conference.muteAudio(true);
241 236
         });
242 237
         this._addShortcutToHelp('SPACE', 'keyboardShortcuts.pushToTalk');
243 238
 

Loading…
취소
저장