Преглед изворни кода

fix(iframe_api): Remove unnecessary div that wraps the iframe

master
hristoterezov пре 8 година
родитељ
комит
3736d6ca78
1 измењених фајлова са 5 додато и 13 уклоњено
  1. 5
    13
      modules/API/external/external_api.js

+ 5
- 13
modules/API/external/external_api.js Прегледај датотеку

229
             width = `${Math.max(width, MIN_WIDTH)}px`;
229
             width = `${Math.max(width, MIN_WIDTH)}px`;
230
         }
230
         }
231
 
231
 
232
-        /* eslint-enable no-param-reassign */
233
-
234
-        this._iframeHolder
235
-            = this._parentNode.appendChild(document.createElement('div'));
236
-        this._iframeHolder.id = `jitsiConference${id}`;
237
-        this._iframeHolder.style.width = width;
238
-        this._iframeHolder.style.height = height;
239
-
240
         const frameName = `jitsiConferenceFrame${id}`;
232
         const frameName = `jitsiConferenceFrame${id}`;
241
 
233
 
242
         this._frame = document.createElement('iframe');
234
         this._frame = document.createElement('iframe');
243
         this._frame.src = this._url;
235
         this._frame.src = this._url;
244
         this._frame.name = frameName;
236
         this._frame.name = frameName;
245
         this._frame.id = frameName;
237
         this._frame.id = frameName;
246
-        this._frame.width = '100%';
247
-        this._frame.height = '100%';
238
+        this._frame.style.width = width;
239
+        this._frame.style.height = height;
248
         this._frame.setAttribute('allowFullScreen', 'true');
240
         this._frame.setAttribute('allowFullScreen', 'true');
249
         this._frame.style.border = 0;
241
         this._frame.style.border = 0;
250
-        this._frame = this._iframeHolder.appendChild(this._frame);
242
+        this._frame = this._parentNode.appendChild(this._frame);
251
     }
243
     }
252
 
244
 
253
     /**
245
     /**
361
     dispose() {
353
     dispose() {
362
         this._transport.dispose();
354
         this._transport.dispose();
363
         this.removeAllListeners();
355
         this.removeAllListeners();
364
-        if (this._iframeHolder) {
365
-            this._iframeHolder._parentNode.removeChild(this._iframeHolder);
356
+        if (this._frame) {
357
+            this._frame.parentNode.removeChild(this._frame);
366
         }
358
         }
367
     }
359
     }
368
 
360
 

Loading…
Откажи
Сачувај