Selaa lähdekoodia

fix(filmstrip): prevent error on updating indicators for shared video

Shared video (youtube videos) do not have indicator icons about
dominant speaker and raised hand. Add a check to see if the
indicator icon container exists before trying to attach react
icons to it. The error thrown didn't seem to be causing any
UI issues though.

While this truthy check before doing ReactDOM.render seems
like it should be a general practice, I'm hesistatnt to make
the change broadly because it hasn't been a problem so far.
master
Leonard Kim 7 vuotta sitten
vanhempi
commit
3aedce11f2
1 muutettua tiedostoa jossa 4 lisäystä ja 0 poistoa
  1. 4
    0
      modules/UI/videolayout/SmallVideo.js

+ 4
- 0
modules/UI/videolayout/SmallVideo.js Näytä tiedosto

776
     const indicatorToolbar
776
     const indicatorToolbar
777
         = this.container.querySelector('.videocontainer__toptoolbar');
777
         = this.container.querySelector('.videocontainer__toptoolbar');
778
 
778
 
779
+    if (!indicatorToolbar) {
780
+        return;
781
+    }
782
+
779
     const iconSize = UIUtil.getIndicatorFontSize();
783
     const iconSize = UIUtil.getIndicatorFontSize();
780
     const showConnectionIndicator = this.videoIsHovered
784
     const showConnectionIndicator = this.videoIsHovered
781
         || !interfaceConfig.CONNECTION_INDICATOR_AUTO_HIDE_ENABLED;
785
         || !interfaceConfig.CONNECTION_INDICATOR_AUTO_HIDE_ENABLED;

Loading…
Peruuta
Tallenna