瀏覽代碼

conference: don't pin participants on the JVB

When a participant is pinned in the UI we then proceed to mark it as selected on
the JVB. This will make the participant part of the last N set and will receive
the highest (or configured highest) video quality.

Pinning a participant at the JVB level just makes sure it will be part of the
last N set.

Since only one participant can be pinned in the UI, there is no point in pinning
it at the JVB level, since selecting it already achieved the same result.
master
Saúl Ibarra Corretgé 5 年之前
父節點
當前提交
5261f61110
共有 1 個文件被更改,包括 0 次插入26 次删除
  1. 0
    26
      react/features/base/conference/middleware.js

+ 0
- 26
react/features/base/conference/middleware.js 查看文件

@@ -14,7 +14,6 @@ import { CONNECTION_ESTABLISHED, CONNECTION_FAILED } from '../connection';
14 14
 import { JitsiConferenceErrors } from '../lib-jitsi-meet';
15 15
 import { setVideoMuted, VIDEO_MUTISM_AUTHORITY } from '../media';
16 16
 import {
17
-    getLocalParticipant,
18 17
     getParticipantById,
19 18
     getPinnedParticipant,
20 19
     PARTICIPANT_UPDATED,
@@ -46,7 +45,6 @@ import {
46 45
     _addLocalTracksToConference,
47 46
     forEachConference,
48 47
     getCurrentConference,
49
-    _handleParticipantError,
50 48
     _removeLocalTracksFromConference
51 49
 } from './functions';
52 50
 
@@ -462,30 +460,6 @@ function _pinParticipant({ getState }, next, action) {
462 460
             }));
463 461
     }
464 462
 
465
-    // The following condition prevents signaling to pin local participant and
466
-    // shared videos. The logic is:
467
-    // - If we have an ID, we check if the participant identified by that ID is
468
-    //   local or a bot/fake participant (such as with shared video).
469
-    // - If we don't have an ID (i.e. no participant identified by an ID), we
470
-    //   check for local participant. If she's currently pinned, then this
471
-    //   action will unpin her and that's why we won't signal here too.
472
-    let pin;
473
-
474
-    if (participantById) {
475
-        pin = !participantById.local && !participantById.isFakeParticipant;
476
-    } else {
477
-        const localParticipant = getLocalParticipant(participants);
478
-
479
-        pin = !localParticipant || !localParticipant.pinned;
480
-    }
481
-    if (pin) {
482
-        try {
483
-            conference.pinParticipant(id);
484
-        } catch (err) {
485
-            _handleParticipantError(err);
486
-        }
487
-    }
488
-
489 463
     return next(action);
490 464
 }
491 465
 

Loading…
取消
儲存