Browse Source

ref(remote-video): set inner html instead of creating elements

This better mimics declarative jsx.
master
Leonard Kim 8 years ago
parent
commit
670d575bcb
1 changed files with 10 additions and 32 deletions
  1. 10
    32
      modules/UI/videolayout/RemoteVideo.js

+ 10
- 32
modules/UI/videolayout/RemoteVideo.js View File

@@ -655,41 +655,19 @@ RemoteVideo.prototype.removePresenceLabel = function () {
655 655
 };
656 656
 
657 657
 RemoteVideo.createContainer = function (spanId) {
658
-    let container = document.createElement('span');
658
+    const container = document.createElement('span');
659 659
     container.id = spanId;
660 660
     container.className = 'videocontainer';
661 661
 
662
-    let wrapper = document.createElement('div');
663
-    wrapper.className = 'videocontainer__background';
664
-    container.appendChild(wrapper);
665
-
666
-    let indicatorBar = document.createElement('div');
667
-    indicatorBar.className = "videocontainer__toptoolbar";
668
-    container.appendChild(indicatorBar);
669
-
670
-    let toolbar = document.createElement('div');
671
-    toolbar.className = "videocontainer__toolbar";
672
-    container.appendChild(toolbar);
673
-
674
-    let overlay = document.createElement('div');
675
-    overlay.className = "videocontainer__hoverOverlay";
676
-    container.appendChild(overlay);
677
-
678
-    const displayNameContainer = document.createElement('div');
679
-    displayNameContainer.className = 'displayNameContainer';
680
-    container.appendChild(displayNameContainer);
681
-
682
-    const avatarContainer = document.createElement('div');
683
-    avatarContainer.className = 'avatar-container';
684
-    container.appendChild(avatarContainer);
685
-
686
-    const presenceLabelContainer = document.createElement('div');
687
-    presenceLabelContainer.className = 'presence-label-container';
688
-    container.appendChild(presenceLabelContainer);
689
-
690
-    const remoteVideoMenuContainer = document.createElement('span');
691
-    remoteVideoMenuContainer.className = 'remotevideomenu';
692
-    container.appendChild(remoteVideoMenuContainer);
662
+    container.innerHTML = `
663
+        <div class = 'videocontainer__background'></div>
664
+        <div class = 'videocontainer__toptoolbar'></div>
665
+        <div class = 'videocontainer__toolbar'></div>
666
+        <div class = 'videocontainer__hoverOverlay'></div>
667
+        <div class = 'displayNameContainer'></div>
668
+        <div class = 'avatar-container'></div>
669
+        <div class ='presence-label-container'></div>
670
+        <span class = 'remotevideomenu'></span>`;
693 671
 
694 672
     var remotes = document.getElementById('filmstripRemoteVideosContainer');
695 673
     return remotes.appendChild(container);

Loading…
Cancel
Save