Bläddra i källkod

ref(deps): remove jquery-ui

After looking at the jquery-ui documentation, I believe it
is being used only in one place, when toggling the smiley
menu. That toggling has been quickly replaced with a normal
jquery call.

Note: @atlassian/aui also uses jquery-ui but killing that
off will be more difficult due to its CSS being used.
master
Leonard Kim 7 år sedan
förälder
incheckning
917fdcaa10
4 ändrade filer med 14 tillägg och 14 borttagningar
  1. 0
    1
      app.js
  2. 2
    7
      modules/UI/side_pannels/chat/Chat.js
  3. 12
    5
      package-lock.json
  4. 0
    1
      package.json

+ 0
- 1
app.js Visa fil

@@ -8,7 +8,6 @@ import './react/features/base/react/prop-types-polyfill.js';
8 8
 
9 9
 import 'jquery';
10 10
 import 'jquery-contextmenu';
11
-import 'jquery-ui';
12 11
 import 'jQuery-Impromptu';
13 12
 import 'autosize';
14 13
 

+ 2
- 7
modules/UI/side_pannels/chat/Chat.js Visa fil

@@ -116,13 +116,8 @@ function getCurrentTime(stamp) {
116 116
 function toggleSmileys() {
117 117
     const smileys = $('#smileysContainer'); // eslint-disable-line no-shadow
118 118
 
119
-    if (smileys.is(':visible')) {
120
-        smileys.hide('slide', { direction: 'down',
121
-            duration: 300 });
122
-    } else {
123
-        smileys.show('slide', { direction: 'down',
124
-            duration: 300 });
125
-    }
119
+    smileys.slideToggle();
120
+
126 121
     $('#usermsg').focus();
127 122
 }
128 123
 

+ 12
- 5
package-lock.json Visa fil

@@ -10175,11 +10175,6 @@
10175 10175
       "resolved": "https://registry.npmjs.org/jquery-i18next/-/jquery-i18next-1.2.0.tgz",
10176 10176
       "integrity": "sha1-jQMDa7ip1v090MX7H+jK0jO94qM="
10177 10177
     },
10178
-    "jquery-ui": {
10179
-      "version": "1.10.5",
10180
-      "resolved": "https://registry.npmjs.org/jquery-ui/-/jquery-ui-1.10.5.tgz",
10181
-      "integrity": "sha1-gmrtPdH4jTKudddN9IZD3EMaWBU="
10182
-    },
10183 10178
     "js-base64": {
10184 10179
       "version": "2.3.2",
10185 10180
       "resolved": "https://registry.npmjs.org/js-base64/-/js-base64-2.3.2.tgz",
@@ -12862,6 +12857,7 @@
12862 12857
         "mkdirp": "0.5.1",
12863 12858
         "normalize-package-data": "2.4.0",
12864 12859
         "npm-package-arg": "4.2.1",
12860
+        "npmlog": "4.1.2",
12865 12861
         "once": "1.4.0",
12866 12862
         "request": "2.83.0",
12867 12863
         "retry": "0.6.1",
@@ -12877,6 +12873,17 @@
12877 12873
           "requires": {
12878 12874
             "natives": "1.1.0"
12879 12875
           }
12876
+        },
12877
+        "npmlog": {
12878
+          "version": "4.1.2",
12879
+          "resolved": "https://registry.npmjs.org/npmlog/-/npmlog-4.1.2.tgz",
12880
+          "integrity": "sha512-2uUqazuKlTaSI/dC8AzicUck7+IrEaOnN/e0jd3Xtt1KcGpwx30v50mL7oPyr/h9bL3E4aZccVwpwP+5W9Vjkg==",
12881
+          "requires": {
12882
+            "are-we-there-yet": "1.1.4",
12883
+            "console-control-strings": "1.1.0",
12884
+            "gauge": "2.7.4",
12885
+            "set-blocking": "2.0.0"
12886
+          }
12880 12887
         }
12881 12888
       }
12882 12889
     },

+ 0
- 1
package.json Visa fil

@@ -44,7 +44,6 @@
44 44
     "jquery": "2.1.4",
45 45
     "jquery-contextmenu": "2.4.5",
46 46
     "jquery-i18next": "1.2.0",
47
-    "jquery-ui": "1.10.5",
48 47
     "js-md5": "0.6.1",
49 48
     "jssha": "2.2.0",
50 49
     "jwt-decode": "2.2.0",

Laddar…
Avbryt
Spara