Procházet zdrojové kódy

fix(thumbnail): cleanup unused hover properties.

master
Hristo Terezov před 4 roky
rodič
revize
a6e58c3101

+ 0
- 12
modules/UI/videolayout/RemoteVideo.js Zobrazit soubor

@@ -86,7 +86,6 @@ export default class RemoteVideo extends SmallVideo {
86 86
         this.bindHoverHandler();
87 87
         this.flipX = false;
88 88
         this.isLocal = false;
89
-        this.popupMenuIsHovered = false;
90 89
         this._isRemoteControlSessionActive = false;
91 90
 
92 91
         /**
@@ -137,17 +136,6 @@ export default class RemoteVideo extends SmallVideo {
137 136
         return this.container;
138 137
     }
139 138
 
140
-    /**
141
-     * Checks whether current video is considered hovered. Currently it is hovered
142
-     * if the mouse is over the video, or if the connection indicator or the popup
143
-     * menu is shown(hovered).
144
-     * @private
145
-     * NOTE: extends SmallVideo's method
146
-     */
147
-    _isHovered() {
148
-        return super._isHovered() || this.popupMenuIsHovered;
149
-    }
150
-
151 139
     /**
152 140
      * Generates the popup menu content.
153 141
      *

+ 1
- 24
modules/UI/videolayout/SmallVideo.js Zobrazit soubor

@@ -100,15 +100,6 @@ export default class SmallVideo {
100 100
          */
101 101
         this._connectionStatus = null;
102 102
 
103
-        /**
104
-         * Whether or not the ConnectionIndicator's popover is hovered. Modifies
105
-         * how the video overlays display based on hover state.
106
-         *
107
-         * @private
108
-         * @type {boolean}
109
-         */
110
-        this._popoverIsHovered = false;
111
-
112 103
         /**
113 104
          * Whether or not the connection indicator should be displayed.
114 105
          *
@@ -134,7 +125,6 @@ export default class SmallVideo {
134 125
         this._showRaisedHand = false;
135 126
 
136 127
         // Bind event handlers so they are only bound once for every instance.
137
-        this._onPopoverHover = this._onPopoverHover.bind(this);
138 128
         this.updateView = this.updateView.bind(this);
139 129
 
140 130
         this._onContainerClick = this._onContainerClick.bind(this);
@@ -513,7 +503,7 @@ export default class SmallVideo {
513 503
      * @private
514 504
      */
515 505
     _isHovered() {
516
-        return this.videoIsHovered || this._popoverIsHovered;
506
+        return this.videoIsHovered;
517 507
     }
518 508
 
519 509
     /**
@@ -836,19 +826,6 @@ export default class SmallVideo {
836 826
         }
837 827
     }
838 828
 
839
-    /**
840
-     * Updates the current state of the connection indicator popover being hovered.
841
-     * If hovered, display the small video as if it is hovered.
842
-     *
843
-     * @param {boolean} popoverIsHovered - Whether or not the mouse cursor is
844
-     * currently over the connection indicator popover.
845
-     * @returns {void}
846
-     */
847
-    _onPopoverHover(popoverIsHovered) {
848
-        this._popoverIsHovered = popoverIsHovered;
849
-        this.updateView();
850
-    }
851
-
852 829
     /**
853 830
      * Sets the size of the thumbnail.
854 831
      */

Načítá se…
Zrušit
Uložit