瀏覽代碼

Detail comment

master
Lyubo Marinov 8 年之前
父節點
當前提交
aaf7a38cce
共有 1 個檔案被更改,包括 9 行新增5 行删除
  1. 9
    5
      react/features/toolbar/components/Toolbar.native.js

+ 9
- 5
react/features/toolbar/components/Toolbar.native.js 查看文件

112
 
112
 
113
         /* eslint-disable react/jsx-curly-spacing,react/jsx-handler-names */
113
         /* eslint-disable react/jsx-curly-spacing,react/jsx-handler-names */
114
 
114
 
115
-        // TODO Use an appropriate icon for toggle camera facing mode.
116
         return (
115
         return (
117
             <View style = { styles.secondaryToolbar }>
116
             <View style = { styles.secondaryToolbar }>
118
-                {/*
119
-                  * XXX Temporarily disabled until issues are fixed in
120
-                  * react-native-webrtc.
117
+                {/* FIXME There are multiple issues with the toggling of the
118
+                  * camera facing more. For example, switching from the user
119
+                  * facing camera to the environment facing camera on iOS may be
120
+                  * very slow or may not work at all. On Android the toggling
121
+                  * either works or does not. The causes of the various problems
122
+                  * have been identified to lie within either
123
+                  * react-native-webrtc or Google's native WebRTC API.
124
+                  *
121
                 <ToolbarButton
125
                 <ToolbarButton
122
                     iconName = 'switch-camera'
126
                     iconName = 'switch-camera'
123
                     iconStyle = { iconStyle }
127
                     iconStyle = { iconStyle }
124
                     onClick = { this._toggleCameraFacingMode }
128
                     onClick = { this._toggleCameraFacingMode }
125
                     style = { style }
129
                     style = { style }
126
                     underlayColor = { underlayColor } />
130
                     underlayColor = { underlayColor } />
127
-                */}
131
+                  */}
128
                 <ToolbarButton
132
                 <ToolbarButton
129
                     iconName = {
133
                     iconName = {
130
                         this.props._locked ? 'security-locked' : 'security'
134
                         this.props._locked ? 'security-locked' : 'security'

Loading…
取消
儲存