Browse Source

ref: Uses config.deploymentInfo instead of window.jitsiDeploymentInfo.

master
Boris Grozev 8 years ago
parent
commit
b09613b943
1 changed files with 7 additions and 11 deletions
  1. 7
    11
      modules/analytics/analytics.js

+ 7
- 11
modules/analytics/analytics.js View File

@@ -4,7 +4,7 @@
4 4
  * Load the integration of a third-party analytics API such as Google
5 5
  * Analytics. Since we cannot guarantee the quality of the third-party service
6 6
  * (e.g. their server may take noticeably long time to respond), it is in our
7
- * best interest (in the sense that the intergration of the analytics API is
7
+ * best interest (in the sense that the integration of the analytics API is
8 8
  * important to us but not enough to allow it to prevent people from joining
9 9
  * a conference) to download the API asynchronously. Additionally, Google
10 10
  * Analytics will download its implementation asynchronously anyway so it makes
@@ -77,7 +77,7 @@ class Analytics {
77 77
             Promise.all(handlersPromises).then(values => {
78 78
                 values.forEach(el => {
79 79
                     if(el.type === "error") {
80
-                        console.log("Fialed to load " + el.url);
80
+                        console.log("Failed to load " + el.url);
81 81
                         console.error(el.error);
82 82
                     }
83 83
                 });
@@ -122,15 +122,11 @@ class Analytics {
122 122
                 if (group) {
123 123
                     permanentProperties.group = group;
124 124
                 }
125
-                /**
126
-                 * optionally include local deployment information,
127
-                 * window.jitsiDeploymentInfo defined outside of application
128
-                 * to use, override contents in local.html
129
-                **/
130
-                if (window.jitsiDeploymentInfo) {
131
-                    for (var key in window.jitsiDeploymentInfo) {
132
-                        permanentProperties[key] 
133
-                            = window.jitsiDeploymentInfo[key];
125
+                 // optionally include local deployment information based on
126
+                 // the contents of window.config.deploymentInfo
127
+                if (config.deploymentInfo) {
128
+                    for (var key in config.deploymentInfo) {
129
+                        permanentProperties[key] = config.deploymentInfo[key];
134 130
                     }
135 131
                 }
136 132
 

Loading…
Cancel
Save