Browse Source

Makes sure we always resolve(call the callback) in feedback dialog.

Call the callback even when clicking outside the dialog, or escaping to close it.
master
damencho 9 years ago
parent
commit
eb2e709749
1 changed files with 7 additions and 5 deletions
  1. 7
    5
      modules/UI/feedback/FeedbackWindow.js

+ 7
- 5
modules/UI/feedback/FeedbackWindow.js View File

176
         });
176
         });
177
         this.$el = this.window.$el;
177
         this.$el = this.window.$el;
178
 
178
 
179
+        AJS.dialog2(selector).on("hide", function() {
180
+            if (this.onCloseCallback) {
181
+                this.onCloseCallback();
182
+                this.onCloseCallback = null;
183
+            }
184
+        }.bind(this));
185
+
179
         this.setState();
186
         this.setState();
180
     }
187
     }
181
 
188
 
201
 
208
 
202
     hide() {
209
     hide() {
203
         this.window.hide();
210
         this.window.hide();
204
-
205
-        if (this.onCloseCallback) {
206
-            this.onCloseCallback();
207
-            this.onCloseCallback = null;
208
-        }
209
     }
211
     }
210
 
212
 
211
     onFeedbackSubmitted() {
213
     onFeedbackSubmitted() {

Loading…
Cancel
Save