瀏覽代碼

subject: avoid sending an extra empty subject update

When setSubject is called too early we store it as pensing, but thanks to the
default parameter value, if undefined is passed to the function we'll store the
empty string.

This will trigger a needless update because undefined !== ''.
master
Saúl Ibarra Corretgé 5 年之前
父節點
當前提交
f230fd4d04
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2
    2
      react/features/base/conference/actions.js

+ 2
- 2
react/features/base/conference/actions.js 查看文件

@@ -763,12 +763,12 @@ export function setStartMutedPolicy(
763 763
  * @param {string} subject - The new subject.
764 764
  * @returns {void}
765 765
  */
766
-export function setSubject(subject: string = '') {
766
+export function setSubject(subject: string) {
767 767
     return (dispatch: Dispatch<any>, getState: Function) => {
768 768
         const { conference } = getState()['features/base/conference'];
769 769
 
770 770
         if (conference) {
771
-            conference.setSubject(subject);
771
+            conference.setSubject(subject || '');
772 772
         } else {
773 773
             dispatch({
774 774
                 type: SET_PENDING_SUBJECT_CHANGE,

Loading…
取消
儲存