소스 검색

fix(thumbnail): cleanup unused hover properties.

master
Hristo Terezov 4 년 전
부모
커밋
a6e58c3101
2개의 변경된 파일1개의 추가작업 그리고 36개의 파일을 삭제
  1. 0
    12
      modules/UI/videolayout/RemoteVideo.js
  2. 1
    24
      modules/UI/videolayout/SmallVideo.js

+ 0
- 12
modules/UI/videolayout/RemoteVideo.js 파일 보기

86
         this.bindHoverHandler();
86
         this.bindHoverHandler();
87
         this.flipX = false;
87
         this.flipX = false;
88
         this.isLocal = false;
88
         this.isLocal = false;
89
-        this.popupMenuIsHovered = false;
90
         this._isRemoteControlSessionActive = false;
89
         this._isRemoteControlSessionActive = false;
91
 
90
 
92
         /**
91
         /**
137
         return this.container;
136
         return this.container;
138
     }
137
     }
139
 
138
 
140
-    /**
141
-     * Checks whether current video is considered hovered. Currently it is hovered
142
-     * if the mouse is over the video, or if the connection indicator or the popup
143
-     * menu is shown(hovered).
144
-     * @private
145
-     * NOTE: extends SmallVideo's method
146
-     */
147
-    _isHovered() {
148
-        return super._isHovered() || this.popupMenuIsHovered;
149
-    }
150
-
151
     /**
139
     /**
152
      * Generates the popup menu content.
140
      * Generates the popup menu content.
153
      *
141
      *

+ 1
- 24
modules/UI/videolayout/SmallVideo.js 파일 보기

100
          */
100
          */
101
         this._connectionStatus = null;
101
         this._connectionStatus = null;
102
 
102
 
103
-        /**
104
-         * Whether or not the ConnectionIndicator's popover is hovered. Modifies
105
-         * how the video overlays display based on hover state.
106
-         *
107
-         * @private
108
-         * @type {boolean}
109
-         */
110
-        this._popoverIsHovered = false;
111
-
112
         /**
103
         /**
113
          * Whether or not the connection indicator should be displayed.
104
          * Whether or not the connection indicator should be displayed.
114
          *
105
          *
134
         this._showRaisedHand = false;
125
         this._showRaisedHand = false;
135
 
126
 
136
         // Bind event handlers so they are only bound once for every instance.
127
         // Bind event handlers so they are only bound once for every instance.
137
-        this._onPopoverHover = this._onPopoverHover.bind(this);
138
         this.updateView = this.updateView.bind(this);
128
         this.updateView = this.updateView.bind(this);
139
 
129
 
140
         this._onContainerClick = this._onContainerClick.bind(this);
130
         this._onContainerClick = this._onContainerClick.bind(this);
513
      * @private
503
      * @private
514
      */
504
      */
515
     _isHovered() {
505
     _isHovered() {
516
-        return this.videoIsHovered || this._popoverIsHovered;
506
+        return this.videoIsHovered;
517
     }
507
     }
518
 
508
 
519
     /**
509
     /**
836
         }
826
         }
837
     }
827
     }
838
 
828
 
839
-    /**
840
-     * Updates the current state of the connection indicator popover being hovered.
841
-     * If hovered, display the small video as if it is hovered.
842
-     *
843
-     * @param {boolean} popoverIsHovered - Whether or not the mouse cursor is
844
-     * currently over the connection indicator popover.
845
-     * @returns {void}
846
-     */
847
-    _onPopoverHover(popoverIsHovered) {
848
-        this._popoverIsHovered = popoverIsHovered;
849
-        this.updateView();
850
-    }
851
-
852
     /**
829
     /**
853
      * Sets the size of the thumbnail.
830
      * Sets the size of the thumbnail.
854
      */
831
      */

Loading…
취소
저장