浏览代码

cleanup desktopsharing events

j8
isymchych 9 年前
父节点
当前提交
335cc6ca6f

+ 8
- 4
app.js 查看文件

17
 import RoomnameGenerator from './modules/util/RoomnameGenerator';
17
 import RoomnameGenerator from './modules/util/RoomnameGenerator';
18
 import CQEvents from './service/connectionquality/CQEvents';
18
 import CQEvents from './service/connectionquality/CQEvents';
19
 import UIEvents from './service/UI/UIEvents';
19
 import UIEvents from './service/UI/UIEvents';
20
+import DSEvents from './service/desktopsharing/DesktopSharingEventTypes';
20
 
21
 
21
 import UI from "./modules/UI/UI";
22
 import UI from "./modules/UI/UI";
22
 import statistics from "./modules/statistics/statistics";
23
 import statistics from "./modules/statistics/statistics";
27
 
28
 
28
 import createRoomLocker from './modules/RoomLocker';
29
 import createRoomLocker from './modules/RoomLocker';
29
 
30
 
30
-const DesktopSharingEventTypes =
31
-    require("./service/desktopsharing/DesktopSharingEventTypes");
32
-
33
 const ConnectionEvents = JitsiMeetJS.events.connection;
31
 const ConnectionEvents = JitsiMeetJS.events.connection;
34
 const ConnectionErrors = JitsiMeetJS.errors.connection;
32
 const ConnectionErrors = JitsiMeetJS.errors.connection;
35
 
33
 
511
         APP.UI.updateDTMFSupport(isDTMFSupported);
509
         APP.UI.updateDTMFSupport(isDTMFSupported);
512
     });
510
     });
513
 
511
 
512
+    APP.UI.addListener(UIEvents.TOGGLE_SCREENSHARING, function () {
513
+        APP.desktopsharing.toggleScreenSharing();
514
+    });
515
+    APP.UI.addListener(DSEvents.SWITCHING_DONE, function (isSharingScreen) {
516
+        APP.UI.updateDesktopSharingButtons(isSharingScreen);
517
+    });
514
     APP.desktopsharing.addListener(
518
     APP.desktopsharing.addListener(
515
-        DesktopSharingEventTypes.NEW_STREAM_CREATED,
519
+        DSEvents.NEW_STREAM_CREATED,
516
         (track, callback) => {
520
         (track, callback) => {
517
             const localCallback = (newTrack) => {
521
             const localCallback = (newTrack) => {
518
                 if (newTrack.isLocal() && newTrack === localVideo) {
522
                 if (newTrack.isLocal() && newTrack === localVideo) {

+ 3
- 5
modules/UI/UI.js 查看文件

11
 import PanelToggler from "./side_pannels/SidePanelToggler";
11
 import PanelToggler from "./side_pannels/SidePanelToggler";
12
 import UIUtil from "./util/UIUtil";
12
 import UIUtil from "./util/UIUtil";
13
 import UIEvents from "../../service/UI/UIEvents";
13
 import UIEvents from "../../service/UI/UIEvents";
14
+import CQEvents from '../../service/connectionquality/CQEvents';
14
 import PreziManager from './prezi/Prezi';
15
 import PreziManager from './prezi/Prezi';
15
 import EtherpadManager from './etherpad/Etherpad';
16
 import EtherpadManager from './etherpad/Etherpad';
16
 
17
 
22
 UI.messageHandler = require("./util/MessageHandler");
23
 UI.messageHandler = require("./util/MessageHandler");
23
 var messageHandler = UI.messageHandler;
24
 var messageHandler = UI.messageHandler;
24
 var JitsiPopover = require("./util/JitsiPopover");
25
 var JitsiPopover = require("./util/JitsiPopover");
25
-var CQEvents = require("../../service/connectionquality/CQEvents");
26
-var DesktopSharingEventTypes
27
-    = require("../../service/desktopsharing/DesktopSharingEventTypes");
28
 var Feedback = require("./Feedback");
26
 var Feedback = require("./Feedback");
29
 
27
 
30
 var eventEmitter = new EventEmitter();
28
 var eventEmitter = new EventEmitter();
599
     VideoLayout.setAudioLevel(id, lvl);
597
     VideoLayout.setAudioLevel(id, lvl);
600
 };
598
 };
601
 
599
 
602
-UI.updateDesktopSharingButtons = function () {
603
-    Toolbar.changeDesktopSharingButtonState();
600
+UI.updateDesktopSharingButtons = function (isSharingScreen) {
601
+    Toolbar.changeDesktopSharingButtonState(isSharingScreen);
604
 };
602
 };
605
 
603
 
606
 UI.hideStats = function () {
604
 UI.hideStats = function () {

+ 3
- 4
modules/UI/toolbars/Toolbar.js 查看文件

136
         } else {
136
         } else {
137
             AnalyticsAdapter.sendEvent('toolbar.screen.enabled');
137
             AnalyticsAdapter.sendEvent('toolbar.screen.enabled');
138
         }
138
         }
139
-        APP.desktopsharing.toggleScreenSharing();
139
+        emitter.emit(UIEvents.TOGGLE_SCREENSHARING);
140
     },
140
     },
141
     "toolbar_button_fullScreen": function() {
141
     "toolbar_button_fullScreen": function() {
142
         AnalyticsAdapter.sendEvent('toolbar.fullscreen.enabled');
142
         AnalyticsAdapter.sendEvent('toolbar.fullscreen.enabled');
309
     // checks whether desktop sharing is enabled and whether
309
     // checks whether desktop sharing is enabled and whether
310
     // we have params to start automatically sharing
310
     // we have params to start automatically sharing
311
     checkAutoEnableDesktopSharing () {
311
     checkAutoEnableDesktopSharing () {
312
-        if (UIUtil.isButtonEnabled('desktop')
313
-            && config.autoEnableDesktopSharing) {
314
-            APP.desktopsharing.toggleScreenSharing();
312
+        if (UIUtil.isButtonEnabled('desktop') && config.autoEnableDesktopSharing) {
313
+            emitter.emit(UIEvents.TOGGLE_SCREENSHARING);
315
         }
314
         }
316
     },
315
     },
317
 
316
 

+ 3
- 7
modules/desktopsharing/desktopsharing.js 查看文件

1
 /* global APP, JitsiMeetJS, config */
1
 /* global APP, JitsiMeetJS, config */
2
 var EventEmitter = require("events");
2
 var EventEmitter = require("events");
3
-var DesktopSharingEventTypes
4
-    = require("../../service/desktopsharing/DesktopSharingEventTypes");
3
+import DSEvents from '../../service/desktopsharing/DesktopSharingEventTypes';
5
 
4
 
6
 const TrackEvents = JitsiMeetJS.events.track;
5
 const TrackEvents = JitsiMeetJS.events.track;
7
 
6
 
27
 
26
 
28
 function streamSwitchDone() {
27
 function streamSwitchDone() {
29
     switchInProgress = false;
28
     switchInProgress = false;
30
-    eventEmitter.emit(
31
-        DesktopSharingEventTypes.SWITCHING_DONE,
32
-        isUsingScreenStream);
29
+    eventEmitter.emit(DSEvents.SWITCHING_DONE, isUsingScreenStream);
33
 }
30
 }
34
 
31
 
35
 function newStreamCreated(track) {
32
 function newStreamCreated(track) {
36
-    eventEmitter.emit(DesktopSharingEventTypes.NEW_STREAM_CREATED,
37
-        track, streamSwitchDone);
33
+    eventEmitter.emit(DSEvents.NEW_STREAM_CREATED, track, streamSwitchDone);
38
 }
34
 }
39
 
35
 
40
 function getVideoStreamFailed() {
36
 function getVideoStreamFailed() {

+ 1
- 0
service/UI/UIEvents.js 查看文件

34
     TOGGLE_SETTINGS: "UI.toggle_settings",
34
     TOGGLE_SETTINGS: "UI.toggle_settings",
35
     TOGGLE_CONTACT_LIST: "UI.toggle_contact_list",
35
     TOGGLE_CONTACT_LIST: "UI.toggle_contact_list",
36
     TOGGLE_FILM_STRIP: "UI.toggle_film_strip",
36
     TOGGLE_FILM_STRIP: "UI.toggle_film_strip",
37
+    TOGGLE_SCREENSHARING: "UI.toggle_screensharing",
37
     CONTACT_CLICKED: "UI.contact_clicked",
38
     CONTACT_CLICKED: "UI.contact_clicked",
38
     HANGUP: "UI.hangup",
39
     HANGUP: "UI.hangup",
39
     LOGOUT: "UI.logout",
40
     LOGOUT: "UI.logout",

+ 1
- 5
service/desktopsharing/DesktopSharingEventTypes.js 查看文件

1
-var DesktopSharingEventTypes = {
2
-    INIT: "ds.init",
3
-
1
+export default {
4
     SWITCHING_DONE: "ds.switching_done",
2
     SWITCHING_DONE: "ds.switching_done",
5
 
3
 
6
     NEW_STREAM_CREATED: "ds.new_stream_created",
4
     NEW_STREAM_CREATED: "ds.new_stream_created",
11
      */
9
      */
12
     FIREFOX_EXTENSION_NEEDED: "ds.firefox_extension_needed"
10
     FIREFOX_EXTENSION_NEEDED: "ds.firefox_extension_needed"
13
 };
11
 };
14
-
15
-module.exports = DesktopSharingEventTypes;

正在加载...
取消
保存