Преглед на файлове

fix(iframe_api): Remove enable/disable events

j8
hristoterezov преди 8 години
родител
ревизия
4a5a1cd5f4
променени са 3 файла, в които са добавени 6 реда и са изтрити 84 реда
  1. 5
    62
      modules/API/API.js
  2. 0
    19
      modules/API/external/external_api.js
  3. 1
    3
      modules/tokendata/TokenData.js

+ 5
- 62
modules/API/API.js Целия файл

@@ -1,5 +1,4 @@
1 1
 /* global APP, getConfigParamsFromUrl */
2
-const logger = require("jitsi-meet-logger").getLogger(__filename);
3 2
 
4 3
 /**
5 4
  * Implements API class that communicates with external api class
@@ -63,31 +62,6 @@ function initCommands() {
63 62
     });
64 63
 }
65 64
 
66
-
67
-/**
68
- * Maps the supported events and their status
69
- * (true it the event is enabled and false if it is disabled)
70
- * @type {{
71
- *              incoming-message: boolean,
72
- *              outgoing-message: boolean,
73
- *              display-name-change: boolean,
74
- *              participant-left: boolean,
75
- *              participant-joined: boolean,
76
- *              video-conference-left: boolean,
77
- *              video-conference-joined: boolean
78
- *      }}
79
- */
80
-const events = {
81
-    "incoming-message": false,
82
-    "outgoing-message":false,
83
-    "display-name-change": false,
84
-    "participant-joined": false,
85
-    "participant-left": false,
86
-    "video-conference-joined": false,
87
-    "video-conference-left": false,
88
-    "video-ready-to-close": false
89
-};
90
-
91 65
 /**
92 66
  * Sends message to the external application.
93 67
  * @param message {object}
@@ -95,27 +69,19 @@ const events = {
95 69
  * @param params {object} the object that will be sent as JSON string
96 70
  */
97 71
 function sendMessage(message) {
98
-    if(enabled)
72
+    if(enabled) {
99 73
         postis.send(message);
74
+    }
100 75
 }
101 76
 
102 77
 /**
103 78
  * Check whether the API should be enabled or not.
104 79
  * @returns {boolean}
105 80
  */
106
-function isEnabled () {
81
+function shouldBeEnabled () {
107 82
     return (typeof jitsi_meet_external_api_id === "number");
108 83
 }
109 84
 
110
-/**
111
- * Checks whether the event is enabled ot not.
112
- * @param name the name of the event.
113
- * @returns {*}
114
- */
115
-function isEventEnabled (name) {
116
-    return events[name];
117
-}
118
-
119 85
 /**
120 86
  * Sends event object to the external application that has been subscribed
121 87
  * for that event.
@@ -123,25 +89,8 @@ function isEventEnabled (name) {
123 89
  * @param object data associated with the event
124 90
  */
125 91
 function triggerEvent (name, object) {
126
-    if(isEventEnabled(name))
92
+    if(enabled) {
127 93
         sendMessage({method: name, params: object});
128
-}
129
-
130
-/**
131
- * Handles system messages. (for example: enable/disable events)
132
- * @param message {object} the message
133
- */
134
-function onSystemMessage(message) {
135
-    switch (message.type) {
136
-        case "eventStatus":
137
-            if(!message.name || !message.value) {
138
-                logger.warn("Unknown system message format", message);
139
-                break;
140
-            }
141
-            events[message.name] = message.value;
142
-            break;
143
-        default:
144
-            logger.warn("Unknown system message type", message);
145 94
     }
146 95
 }
147 96
 
@@ -153,17 +102,12 @@ export default {
153 102
      * is initialized.
154 103
      * @param options {object}
155 104
      * @param forceEnable {boolean} if true the module will be enabled.
156
-     * @param enabledEvents {array} array of events that should be enabled.
157 105
      */
158 106
     init (options = {}) {
159
-        if(!isEnabled() && !options.forceEnable)
107
+        if(!shouldBeEnabled() && !options.forceEnable)
160 108
             return;
161 109
 
162 110
         enabled = true;
163
-        if(options.enabledEvents)
164
-            options.enabledEvents.forEach(function (eventName) {
165
-                events[eventName] = true;
166
-            });
167 111
         let postisOptions = {
168 112
             window: target
169 113
         };
@@ -171,7 +115,6 @@ export default {
171 115
             postisOptions.scope
172 116
                 = "jitsi_meet_external_api_" + jitsi_meet_external_api_id;
173 117
         postis = postisInit(postisOptions);
174
-        postis.listen("jitsiSystemMessage", onSystemMessage);
175 118
         initCommands();
176 119
     },
177 120
 

+ 0
- 19
modules/API/external/external_api.js Целия файл

@@ -68,23 +68,6 @@ function sendMessage(postis, object) {
68 68
     postis.send(object);
69 69
 }
70 70
 
71
-/**
72
- * Sends message for event enable/disable status change.
73
- * @param postis {Postis object} the postis instance that is going to be used.
74
- * @param event {string} the name of the event
75
- * @param status {boolean} true - enabled; false - disabled;
76
- */
77
-function changeEventStatus(postis, event, status) {
78
-    if(!(event in events)) {
79
-        logger.error("Not supported event name.");
80
-        return;
81
-    }
82
-    sendMessage(postis, {
83
-        method: "jitsiSystemMessage",
84
-        params: {type: "eventStatus", name: events[event], value: status}
85
-    });
86
-}
87
-
88 71
 /**
89 72
  * Adds given number to the numberOfParticipants property of given APIInstance.
90 73
  * @param {JitsiMeetExternalAPI} APIInstance the instance of the
@@ -340,7 +323,6 @@ JitsiMeetExternalAPI.prototype.addEventListener = function(event, listener) {
340 323
         this.postisListeners[event] = true;
341 324
     }
342 325
     this.eventHandlers[event] = listener;
343
-    changeEventStatus(this.postis, event, true);
344 326
 };
345 327
 
346 328
 /**
@@ -354,7 +336,6 @@ JitsiMeetExternalAPI.prototype.removeEventListener = function(event) {
354 336
         return;
355 337
     }
356 338
     delete this.eventHandlers[event];
357
-    changeEventStatus(this.postis, event, false);
358 339
 };
359 340
 
360 341
 /**

+ 1
- 3
modules/tokendata/TokenData.js Целия файл

@@ -75,9 +75,7 @@ class TokenData{
75 75
 
76 76
         //External API settings
77 77
         this.externalAPISettings = {
78
-            forceEnable: true,
79
-            enabledEvents: ["video-conference-joined", "video-conference-left",
80
-                "video-ready-to-close"]
78
+            forceEnable: true
81 79
         };
82 80
         this._decode();
83 81
         // Use JWT param as token if there is not other token set and if the

Loading…
Отказ
Запис