Browse Source

android: simplify code

- No need to handle the activity result in the fragment, since we already do in
  the Activity
- Automagically ddispose the view when destroyed
j8
Saúl Ibarra Corretgé 5 years ago
parent
commit
65a8091e53

+ 0
- 16
android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetFragment.java View File

@@ -57,22 +57,6 @@ public class JitsiMeetFragment extends Fragment {
57 57
         return view;
58 58
     }
59 59
 
60
-    @Override
61
-    public void onActivityResult(int requestCode, int resultCode, Intent data) {
62
-        JitsiMeetActivityDelegate.onActivityResult(
63
-                getActivity(), requestCode, resultCode, data);
64
-    }
65
-
66
-    @Override
67
-    public void onDestroyView() {
68
-        if (view != null) {
69
-            view.dispose();
70
-            view = null;
71
-        }
72
-
73
-        super.onDestroyView();
74
-    }
75
-
76 60
     @Override
77 61
     public void onDestroy() {
78 62
         super.onDestroy();

+ 6
- 0
android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetView.java View File

@@ -201,4 +201,10 @@ public class JitsiMeetView extends BaseReactView<JitsiMeetViewListener>
201 201
     protected void onExternalAPIEvent(String name, ReadableMap data) {
202 202
         onExternalAPIEvent(LISTENER_METHODS, name, data);
203 203
     }
204
+
205
+    @Override
206
+    protected void onDetachedFromWindow() {
207
+        dispose();
208
+        super.onDetachedFromWindow();
209
+    }
204 210
 }

Loading…
Cancel
Save