瀏覽代碼

Fix typos and rename event names for purposes of clarity.

j8
Boris Grozev 10 年之前
父節點
當前提交
886fb2ac43
共有 6 個文件被更改,包括 25 次插入22 次删除
  1. 2
    2
      modules/API/API.js
  2. 1
    1
      modules/RTC/RTC.js
  3. 7
    7
      modules/UI/UI.js
  4. 1
    1
      modules/xmpp/moderator.js
  5. 5
    5
      modules/xmpp/strophe.emuc.js
  6. 9
    6
      service/xmpp/XMPPEvents.js

+ 2
- 2
modules/API/API.js 查看文件

@@ -135,7 +135,7 @@ function processMessage(event)
135 135
 }
136 136
 
137 137
 function setupListeners() {
138
-    APP.xmpp.addListener(XMPPEvents.MUC_ENTER, function (from) {
138
+    APP.xmpp.addListener(XMPPEvents.MUC_MEMBER_JOINED, function (from) {
139 139
         API.triggerEvent("participantJoined", {jid: from});
140 140
     });
141 141
     APP.xmpp.addListener(XMPPEvents.MESSAGE_RECEIVED, function (from, nick, txt, myjid) {
@@ -143,7 +143,7 @@ function setupListeners() {
143 143
             API.triggerEvent("incomingMessage",
144 144
                 {"from": from, "nick": nick, "message": txt});
145 145
     });
146
-    APP.xmpp.addListener(XMPPEvents.MUC_LEFT, function (jid) {
146
+    APP.xmpp.addListener(XMPPEvents.MUC_MEMBER_LEFT, function (jid) {
147 147
         API.triggerEvent("participantLeft", {jid: jid});
148 148
     });
149 149
     APP.xmpp.addListener(XMPPEvents.DISPLAY_NAME_CHANGED, function (jid, newDisplayName) {

+ 1
- 1
modules/RTC/RTC.js 查看文件

@@ -117,7 +117,7 @@ var RTC = {
117 117
             function (stream, isUsingScreenStream, callback) {
118 118
                 self.changeLocalVideo(stream, isUsingScreenStream, callback);
119 119
             }, DesktopSharingEventTypes.NEW_STREAM_CREATED);
120
-        APP.xmpp.addListener(XMPPEvents.CHANGED_STREAMS, function (jid, changedStreams) {
120
+        APP.xmpp.addListener(XMPPEvents.STREAMS_CHANGED, function (jid, changedStreams) {
121 121
             for(var i = 0; i < changedStreams.length; i++) {
122 122
                 var type = changedStreams[i].type;
123 123
                 if (type != "audio") {

+ 7
- 7
modules/UI/UI.js 查看文件

@@ -185,7 +185,7 @@ function registerListeners() {
185 185
     APP.xmpp.addListener(XMPPEvents.USER_ID_CHANGED, function (from, id) {
186 186
         Avatar.setUserAvatar(from, id);
187 187
     });
188
-    APP.xmpp.addListener(XMPPEvents.CHANGED_STREAMS, function (jid, changedStreams) {
188
+    APP.xmpp.addListener(XMPPEvents.STREAMS_CHANGED, function (jid, changedStreams) {
189 189
         for(stream in changedStreams)
190 190
         {
191 191
             // might need to update the direction if participant just went from sendrecv to recvonly
@@ -207,13 +207,13 @@ function registerListeners() {
207 207
     });
208 208
     APP.xmpp.addListener(XMPPEvents.DISPLAY_NAME_CHANGED, onDisplayNameChanged);
209 209
     APP.xmpp.addListener(XMPPEvents.MUC_JOINED, onMucJoined);
210
-    APP.xmpp.addListener(XMPPEvents.LOCALROLE_CHANGED, onLocalRoleChange);
211
-    APP.xmpp.addListener(XMPPEvents.MUC_ENTER, onMucEntered);
210
+    APP.xmpp.addListener(XMPPEvents.LOCAL_ROLE_CHANGED, onLocalRoleChanged);
211
+    APP.xmpp.addListener(XMPPEvents.MUC_MEMBER_JOINED, onMucMemberJoined);
212 212
     APP.xmpp.addListener(XMPPEvents.MUC_ROLE_CHANGED, onMucRoleChanged);
213 213
     APP.xmpp.addListener(XMPPEvents.PRESENCE_STATUS, onMucPresenceStatus);
214 214
     APP.xmpp.addListener(XMPPEvents.SUBJECT_CHANGED, chatSetSubject);
215 215
     APP.xmpp.addListener(XMPPEvents.MESSAGE_RECEIVED, updateChatConversation);
216
-    APP.xmpp.addListener(XMPPEvents.MUC_LEFT, onMucLeft);
216
+    APP.xmpp.addListener(XMPPEvents.MUC_MEMBER_LEFT, onMucMemberLeft);
217 217
     APP.xmpp.addListener(XMPPEvents.PASSWORD_REQUIRED, onPasswordRequired);
218 218
     APP.xmpp.addListener(XMPPEvents.CHAT_ERROR_RECEIVED, chatAddError);
219 219
     APP.xmpp.addListener(XMPPEvents.ETHERPAD, initEtherpad);
@@ -417,7 +417,7 @@ function initEtherpad(name) {
417 417
     Etherpad.init(name);
418 418
 };
419 419
 
420
-function onMucLeft(jid) {
420
+function onMucMemberLeft(jid) {
421 421
     console.log('left.muc', jid);
422 422
     var displayName = $('#participant_' + Strophe.getResourceFromJid(jid) +
423 423
         '>.displayname').html();
@@ -444,7 +444,7 @@ function onMucLeft(jid) {
444 444
 };
445 445
 
446 446
 
447
-function onLocalRoleChange(jid, info, pres, isModerator)
447
+function onLocalRoleChanged(jid, info, pres, isModerator)
448 448
 {
449 449
 
450 450
     console.info("My role changed, new role: " + info.role);
@@ -502,7 +502,7 @@ function onPasswordRequired(callback) {
502 502
         ':input:first'
503 503
     );
504 504
 }
505
-function onMucEntered(jid, id, displayName) {
505
+function onMucMemberJoined(jid, id, displayName) {
506 506
     messageHandler.notify(displayName,'notify.somebody',
507 507
         'connected',
508 508
         'notify.connected');

+ 1
- 1
modules/xmpp/moderator.js 查看文件

@@ -85,7 +85,7 @@ var Moderator = {
85 85
         }
86 86
     },
87 87
 
88
-    onMucLeft: function (jid) {
88
+    onMucMemberLeft: function (jid) {
89 89
         console.info("Someone left is it focus ? " + jid);
90 90
         var resource = Strophe.getResourceFromJid(jid);
91 91
         if (resource === 'focus' && !this.xmppService.sessionTerminated) {

+ 5
- 5
modules/xmpp/strophe.emuc.js 查看文件

@@ -201,7 +201,7 @@ module.exports = function(XMPP, eventEmitter) {
201 201
                 if (this.role !== member.role) {
202 202
                     this.role = member.role;
203 203
 
204
-                    eventEmitter.emit(XMPPEvents.LOCALROLE_CHANGED,
204
+                    eventEmitter.emit(XMPPEvents.LOCAL_ROLE_CHANGED,
205 205
                         from, member, pres, Moderator.isModerator());
206 206
                 }
207 207
                 if (!this.joined) {
@@ -224,7 +224,7 @@ module.exports = function(XMPP, eventEmitter) {
224 224
                     if (email.length > 0) {
225 225
                         id = email.text();
226 226
                     }
227
-                    eventEmitter.emit(XMPPEvents.MUC_ENTER, from, id, member.displayName);
227
+                    eventEmitter.emit(XMPPEvents.MUC_MEMBER_JOINED, from, id, member.displayName);
228 228
                 }
229 229
             } else {
230 230
                 // Presence update for existing participant
@@ -584,7 +584,7 @@ module.exports = function(XMPP, eventEmitter) {
584 584
         },
585 585
         onParticipantLeft: function (jid) {
586 586
 
587
-            eventEmitter.emit(XMPPEvents.MUC_LEFT, jid);
587
+            eventEmitter.emit(XMPPEvents.MUC_MEMBER_LEFT, jid);
588 588
 
589 589
             this.connection.jingle.terminateByJid(jid);
590 590
 
@@ -593,7 +593,7 @@ module.exports = function(XMPP, eventEmitter) {
593 593
                     [jid, this.getPrezi(jid)]);
594 594
             }
595 595
 
596
-            Moderator.onMucLeft(jid);
596
+            Moderator.onMucMemberLeft(jid);
597 597
         },
598 598
         parsePresence: function (from, memeber, pres) {
599 599
             if($(pres).find(">bridgeIsDown").length > 0 && !bridgeIsDown) {
@@ -628,7 +628,7 @@ module.exports = function(XMPP, eventEmitter) {
628 628
 
629 629
             });
630 630
 
631
-            eventEmitter.emit(XMPPEvents.CHANGED_STREAMS, from, changedStreams);
631
+            eventEmitter.emit(XMPPEvents.STREAMS_CHANGED, from, changedStreams);
632 632
 
633 633
             var displayName = !config.displayJids
634 634
                 ? memeber.displayName : Strophe.getResourceFromJid(from);

+ 9
- 6
service/xmpp/XMPPEvents.js 查看文件

@@ -1,21 +1,24 @@
1 1
 var XMPPEvents = {
2
-    CONFERENCE_CERATED: "xmpp.conferenceCreated.jingle",
2
+    CONFERENCE_CREATED: "xmpp.conferenceCreated.jingle",
3 3
     CALL_TERMINATED: "xmpp.callterminated.jingle",
4 4
     CALL_INCOMING: "xmpp.callincoming.jingle",
5
-    DISPOSE_CONFERENCE: "xmpp.dispoce_confernce",
5
+    DISPOSE_CONFERENCE: "xmpp.dispose_conference",
6 6
     GRACEFUL_SHUTDOWN: "xmpp.graceful_shutdown",
7 7
     KICKED: "xmpp.kicked",
8 8
     BRIDGE_DOWN: "xmpp.bridge_down",
9 9
     USER_ID_CHANGED: "xmpp.user_id_changed",
10
-    CHANGED_STREAMS: "xmpp.changed_streams",
10
+    STREAMS_CHANGED: "xmpp.streams_changed",
11
+    // We joined the MUC
11 12
     MUC_JOINED: "xmpp.muc_joined",
12
-    MUC_ENTER: "xmpp.muc_enter",
13
+    // A member joined the MUC
14
+    MUC_MEMBER_JOINED: "xmpp.muc_member_joined",
15
+    // A member left the MUC
16
+    MUC_MEMBER_LEFT: "xmpp.muc_member_left",
13 17
     MUC_ROLE_CHANGED: "xmpp.muc_role_changed",
14
-    MUC_LEFT: "xmpp.muc_left",
15 18
     MUC_DESTROYED: "xmpp.muc_destroyed",
16 19
     DISPLAY_NAME_CHANGED: "xmpp.display_name_changed",
17 20
     REMOTE_STATS: "xmpp.remote_stats",
18
-    LOCALROLE_CHANGED: "xmpp.localrole_changed",
21
+    LOCAL_ROLE_CHANGED: "xmpp.localrole_changed",
19 22
     PRESENCE_STATUS: "xmpp.presence_status",
20 23
     RESERVATION_ERROR: "xmpp.room_reservation_error",
21 24
     SUBJECT_CHANGED: "xmpp.subject_changed",

Loading…
取消
儲存