Explorar el Código

feat(DisplayName): Limit local and remote display name to 50 chars

j8
hristoterezov hace 9 años
padre
commit
a6a7e81a0f
Se han modificado 1 ficheros con 16 adiciones y 7 borrados
  1. 16
    7
      conference.js

+ 16
- 7
conference.js Ver fichero

54
     CUSTOM_ROLE: "custom-role"
54
     CUSTOM_ROLE: "custom-role"
55
 };
55
 };
56
 
56
 
57
+/**
58
+ * Max length of the display names. If we receive longer display name the
59
+ * additional chars are going to be cut.
60
+ */
61
+const MAX_DISPLAYNAME_LENGTH = 50;
62
+
57
 /**
63
 /**
58
  * Open Connection. When authentication failed it shows auth dialog.
64
  * Open Connection. When authentication failed it shows auth dialog.
59
  * @param roomName the room name to use
65
  * @param roomName the room name to use
281
  * @param nickname {string} the new display name
287
  * @param nickname {string} the new display name
282
  */
288
  */
283
 function changeLocalDisplayName(nickname = '') {
289
 function changeLocalDisplayName(nickname = '') {
284
-    nickname = nickname.trim();
290
+    const formattedNickname
291
+        = nickname.trim().substr(0, MAX_DISPLAYNAME_LENGTH);
285
 
292
 
286
-    if (nickname === APP.settings.getDisplayName()) {
293
+    if (formattedNickname === APP.settings.getDisplayName()) {
287
         return;
294
         return;
288
     }
295
     }
289
 
296
 
290
-    APP.settings.setDisplayName(nickname);
291
-    room.setDisplayName(nickname);
292
-    APP.UI.changeDisplayName(APP.conference.getMyUserId(), nickname);
297
+    APP.settings.setDisplayName(formattedNickname);
298
+    room.setDisplayName(formattedNickname);
299
+    APP.UI.changeDisplayName(APP.conference.getMyUserId(), formattedNickname);
293
 }
300
 }
294
 
301
 
295
 class ConferenceConnector {
302
 class ConferenceConnector {
1268
         });
1275
         });
1269
 
1276
 
1270
         room.on(ConferenceEvents.DISPLAY_NAME_CHANGED, (id, displayName) => {
1277
         room.on(ConferenceEvents.DISPLAY_NAME_CHANGED, (id, displayName) => {
1271
-            APP.API.notifyDisplayNameChanged(id, displayName);
1272
-            APP.UI.changeDisplayName(id, displayName);
1278
+            const formattedDisplayName
1279
+                = displayName.substr(0, MAX_DISPLAYNAME_LENGTH);
1280
+            APP.API.notifyDisplayNameChanged(id, formattedDisplayName);
1281
+            APP.UI.changeDisplayName(id, formattedDisplayName);
1273
         });
1282
         });
1274
 
1283
 
1275
         room.on(ConferenceEvents.PARTICIPANT_PROPERTY_CHANGED,
1284
         room.on(ConferenceEvents.PARTICIPANT_PROPERTY_CHANGED,

Loading…
Cancelar
Guardar