Просмотр исходного кода

rn,filmstrip: don't unpin participant when hiding filmstrip

The filmstrip is currently only hidden when PiP mode is entered. There is no
real reason not to leave the large view as it was.
j8
Saúl Ibarra Corretgé 6 лет назад
Родитель
Сommit
b5489b7c81
1 измененных файлов: 1 добавлений и 6 удалений
  1. 1
    6
      react/features/filmstrip/middleware.js

+ 1
- 6
react/features/filmstrip/middleware.js Просмотреть файл

1
 // @flow
1
 // @flow
2
 
2
 
3
 import { setLastN } from '../base/conference';
3
 import { setLastN } from '../base/conference';
4
-import { pinParticipant } from '../base/participants';
5
 import { MiddlewareRegistry } from '../base/redux';
4
 import { MiddlewareRegistry } from '../base/redux';
6
 
5
 
7
 import { SET_FILMSTRIP_ENABLED } from './actionTypes';
6
 import { SET_FILMSTRIP_ENABLED } from './actionTypes';
33
 function _setFilmstripEnabled({ dispatch, getState }, next, action) {
32
 function _setFilmstripEnabled({ dispatch, getState }, next, action) {
34
     const result = next(action);
33
     const result = next(action);
35
 
34
 
36
-    // FIXME The logic for participant pinning / unpinning is not on React yet
37
-    // so dispatching the action is not enough. Hence, perform the following
38
-    // only where it will be sufficient i.e. mobile.
35
+    // FIXME This action is not currently dispatched on web.
39
     if (typeof APP === 'undefined') {
36
     if (typeof APP === 'undefined') {
40
         const state = getState();
37
         const state = getState();
41
         const { enabled } = state['features/filmstrip'];
38
         const { enabled } = state['features/filmstrip'];
42
         const { audioOnly } = state['features/base/conference'];
39
         const { audioOnly } = state['features/base/conference'];
43
 
40
 
44
-        enabled || dispatch(pinParticipant(null));
45
-
46
         // FIXME Audio-only mode fiddles with lastN as well. That's why we don't
41
         // FIXME Audio-only mode fiddles with lastN as well. That's why we don't
47
         // touch lastN in audio-only mode. But it's not clear what the value of
42
         // touch lastN in audio-only mode. But it's not clear what the value of
48
         // lastN should be upon exit from audio-only mode if the filmstrip is
43
         // lastN should be upon exit from audio-only mode if the filmstrip is

Загрузка…
Отмена
Сохранить