Browse Source

Prevent undefined JitsiMeetJS

j8
Lyubo Marinov 8 years ago
parent
commit
c1b9b7a623

+ 1
- 3
react/features/base/conference/actions.js View File

@@ -1,4 +1,4 @@
1
-import JitsiMeetJS from '../lib-jitsi-meet';
1
+import { JitsiConferenceEvents } from '../lib-jitsi-meet';
2 2
 import {
3 3
     changeParticipantEmail,
4 4
     dominantSpeakerChanged,
@@ -30,8 +30,6 @@ import { _addLocalTracksToConference } from './functions';
30 30
  * @returns {void}
31 31
  */
32 32
 function _addConferenceListeners(conference, dispatch) {
33
-    const JitsiConferenceEvents = JitsiMeetJS.events.conference;
34
-
35 33
     conference.on(
36 34
             JitsiConferenceEvents.CONFERENCE_FAILED,
37 35
             (...args) => dispatch(conferenceFailed(conference, ...args)));

+ 1
- 3
react/features/base/conference/functions.js View File

@@ -1,6 +1,4 @@
1
-import JitsiMeetJS from '../lib-jitsi-meet';
2
-
3
-const JitsiTrackErrors = JitsiMeetJS.errors.track;
1
+import { JitsiTrackErrors } from '../lib-jitsi-meet';
4 2
 
5 3
 /**
6 4
  * Attach a set of local tracks to a conference.

+ 1
- 2
react/features/base/conference/reducer.js View File

@@ -1,4 +1,4 @@
1
-import JitsiMeetJS from '../lib-jitsi-meet';
1
+import { JitsiConferenceErrors } from '../lib-jitsi-meet';
2 2
 import {
3 3
     ReducerRegistry,
4 4
     setStateProperties,
@@ -64,7 +64,6 @@ function _conferenceFailed(state, action) {
64 64
         return state;
65 65
     }
66 66
 
67
-    const JitsiConferenceErrors = JitsiMeetJS.errors.conference;
68 67
     const passwordRequired
69 68
         = JitsiConferenceErrors.PASSWORD_REQUIRED === action.error
70 69
             ? conference

+ 1
- 3
react/features/base/connection/actions.native.js View File

@@ -3,7 +3,7 @@
3 3
 import type { Dispatch } from 'redux';
4 4
 
5 5
 import { conferenceWillLeave } from '../conference';
6
-import JitsiMeetJS from '../lib-jitsi-meet';
6
+import JitsiMeetJS, { JitsiConnectionEvents } from '../lib-jitsi-meet';
7 7
 
8 8
 import {
9 9
     CONNECTION_DISCONNECTED,
@@ -12,8 +12,6 @@ import {
12 12
     SET_DOMAIN
13 13
 } from './actionTypes';
14 14
 
15
-const JitsiConnectionEvents = JitsiMeetJS.events.connection;
16
-
17 15
 /**
18 16
  * Opens new connection.
19 17
  *

+ 2
- 2
react/features/base/connection/actions.web.js View File

@@ -2,14 +2,14 @@
2 2
 
3 3
 import type { Dispatch } from 'redux';
4 4
 
5
+import { JitsiConferenceEvents } from '../lib-jitsi-meet';
6
+
5 7
 import UIEvents from '../../../../service/UI/UIEvents';
6 8
 
7 9
 import { SET_DOMAIN } from './actionTypes';
8 10
 
9 11
 declare var APP: Object;
10
-declare var JitsiMeetJS: Object;
11 12
 
12
-const JitsiConferenceEvents = JitsiMeetJS.events.conference;
13 13
 const logger = require('jitsi-meet-logger').getLogger(__filename);
14 14
 
15 15
 export {

+ 1
- 3
react/features/base/lib-jitsi-meet/actions.js View File

@@ -1,8 +1,6 @@
1
-/* @flow */
2
-
3 1
 import type { Dispatch } from 'redux';
4 2
 
5
-import JitsiMeetJS from './';
3
+import JitsiMeetJS from './_';
6 4
 import {
7 5
     LIB_DID_DISPOSE,
8 6
     LIB_DID_INIT,

+ 10
- 0
react/features/base/lib-jitsi-meet/index.js View File

@@ -3,6 +3,16 @@
3 3
 import JitsiMeetJS from './_';
4 4
 export { JitsiMeetJS as default };
5 5
 
6
+// XXX Re-export the types exported by JitsiMeetJS in order to prevent undefined
7
+// imported JitsiMeetJS. It may be caused by import cycles but I have not
8
+// confirmed the theory.
9
+export const JitsiConferenceErrors = JitsiMeetJS.errors.conference;
10
+export const JitsiConferenceEvents = JitsiMeetJS.events.conference;
11
+export const JitsiConnectionErrors = JitsiMeetJS.errors.connection;
12
+export const JitsiConnectionEvents = JitsiMeetJS.events.connection;
13
+export const JitsiTrackErrors = JitsiMeetJS.errors.track;
14
+export const JitsiTrackEvents = JitsiMeetJS.events.track;
15
+
6 16
 export * from './actions';
7 17
 export * from './actionTypes';
8 18
 export * from './functions';

+ 4
- 4
react/features/base/tracks/actions.js View File

@@ -1,4 +1,7 @@
1
-import JitsiMeetJS from '../lib-jitsi-meet';
1
+import JitsiMeetJS, {
2
+    JitsiTrackErrors,
3
+    JitsiTrackEvents
4
+} from '../lib-jitsi-meet';
2 5
 import {
3 6
     CAMERA_FACING_MODE,
4 7
     MEDIA_TYPE
@@ -11,9 +14,6 @@ import {
11 14
     TRACK_UPDATED
12 15
 } from './actionTypes';
13 16
 
14
-const JitsiTrackErrors = JitsiMeetJS.errors.track;
15
-const JitsiTrackEvents = JitsiMeetJS.events.track;
16
-
17 17
 /**
18 18
  * Request to start capturing local audio and/or video. By default, the user
19 19
  * facing camera will be selected.

+ 4
- 4
react/features/overlay/reducer.js View File

@@ -3,8 +3,10 @@ import {
3 3
     CONNECTION_ESTABLISHED,
4 4
     CONNECTION_FAILED
5 5
 } from '../base/connection';
6
-import JitsiMeetJS, {
7
-    isFatalJitsiConnectionError
6
+import {
7
+    isFatalJitsiConnectionError,
8
+    JitsiConferenceErrors,
9
+    JitsiConnectionErrors
8 10
 } from '../base/lib-jitsi-meet';
9 11
 import {
10 12
     ReducerRegistry,
@@ -17,8 +19,6 @@ import {
17 19
     SUSPEND_DETECTED
18 20
 } from './actionTypes';
19 21
 
20
-const JitsiConferenceErrors = JitsiMeetJS.errors.conference;
21
-const JitsiConnectionErrors = JitsiMeetJS.errors.connection;
22 22
 const logger = require('jitsi-meet-logger').getLogger(__filename);
23 23
 
24 24
 /**

Loading…
Cancel
Save