Bladeren bron

fix(filmstrip): do not apply flex on local video for horizontal mode

Firefox flex behaves differently from chrome. In firefox, flex
is not allowing the local video and invite button to exceed
the height of the parent, causing the local video to display
shorter than expected due to the invite button. Flex doesn't
need to be applied for local video in horizontal filmstrip
mode as it's only needed in vertical filmstrip mode to
flip the position of the invite button from above the local
video to below. Honestly, this could be better off done
declaratively in the html, but that's not as straigtforward
in this jquery+react world.
j8
Leonard Kim 8 jaren geleden
bovenliggende
commit
c345c0d5e8
2 gewijzigde bestanden met toevoegingen van 2 en 1 verwijderingen
  1. 1
    1
      css/_filmstrip.scss
  2. 1
    0
      css/_vertical_filmstrip_overrides.scss

+ 1
- 1
css/_filmstrip.scss Bestand weergeven

@@ -65,7 +65,7 @@
65 65
          */
66 66
         &#filmstripLocalVideo {
67 67
             bottom: 32px;
68
-            flex-direction: column;
68
+            display: block;
69 69
 
70 70
             /**
71 71
              * The invite button style.

+ 1
- 0
css/_vertical_filmstrip_overrides.scss Bestand weergeven

@@ -56,6 +56,7 @@
56 56
          */
57 57
         #filmstripLocalVideo {
58 58
             bottom: 5px;
59
+            display: flex;
59 60
             flex-direction: column-reverse;
60 61
             height: auto;
61 62
             justify-content: flex-start;

Laden…
Annuleren
Opslaan