Browse Source

Merge branch 'master' of github.com:jitsi/jitsi-meet

j8
hristoterezov 10 years ago
parent
commit
cea0916bfd
2 changed files with 11 additions and 8 deletions
  1. 1
    1
      conference.js
  2. 10
    7
      modules/UI/videolayout/RemoteVideo.js

+ 1
- 1
conference.js View File

@@ -104,7 +104,7 @@ class ConferenceConnector {
104 104
         this._reject(err);
105 105
     }
106 106
     _onConferenceFailed(err, ...params) {
107
-        console.error('CONFERENCE FAILED:', err, params);
107
+        console.error('CONFERENCE FAILED:', err, ...params);
108 108
         switch (err) {
109 109
             // room is locked by the password
110 110
         case ConferenceErrors.PASSWORD_REQUIRED:

+ 10
- 7
modules/UI/videolayout/RemoteVideo.js View File

@@ -86,13 +86,12 @@ if (!interfaceConfig.filmStripOnly) {
86 86
             muteLinkItem.className = 'mutelink disabled';
87 87
         }
88 88
 
89
-        var self = this;
90
-        muteLinkItem.onclick = function(){
89
+        muteLinkItem.onclick = (event) => {
91 90
             if ($(this).attr('disabled')) {
92 91
                 event.preventDefault();
93 92
             }
94
-            var isMute = !!self.isMuted;
95
-            self.emitter.emit(UIEvents.REMOTE_AUDIO_MUTED, self.id);
93
+            var isMute = !!this.isMuted;
94
+            this.emitter.emit(UIEvents.REMOTE_AUDIO_MUTED, this.id);
96 95
 
97 96
             popupmenuElement.setAttribute('style', 'display:none;');
98 97
 
@@ -120,8 +119,8 @@ if (!interfaceConfig.filmStripOnly) {
120 119
         var ejectText = "<div style='width: 90px;margin-left: 20px;' " +
121 120
             "data-i18n='videothumbnail.kick'>&nbsp;</div>";
122 121
         ejectLinkItem.innerHTML = ejectIndicator + ' ' + ejectText;
123
-        ejectLinkItem.onclick = function(){
124
-            self.emitter.emit(UIEvents.USER_KICKED, self.id);
122
+        ejectLinkItem.onclick = (event) => {
123
+            this.emitter.emit(UIEvents.USER_KICKED, this.id);
125 124
             popupmenuElement.setAttribute('style', 'display:none;');
126 125
         };
127 126
 
@@ -224,8 +223,12 @@ RemoteVideo.prototype.addRemoteStreamElement = function (stream) {
224 223
 
225 224
     // Add click handler.
226 225
     let onClickHandler = (event) => {
226
+        let source = event.target || event.srcElement;
227 227
 
228
-        this.VideoLayout.handleVideoThumbClicked(false, this.id);
228
+        // ignore click if it was done in popup menu
229
+        if ($(source).parents('.popupmenu').length === 0) {
230
+            this.VideoLayout.handleVideoThumbClicked(false, this.id);
231
+        }
229 232
 
230 233
         // On IE we need to populate this handler on video <object>
231 234
         // and it does not give event instance as an argument,

Loading…
Cancel
Save