Selaa lähdekoodia

Adds a FIXME (comment) to make a note of the fact that loading analytics.js after modules/statistics/AnalyticsAdapter.js forces the method AnalyticsAdapter.sendEvent to a no-op.

j8
Lyubomir Marinov 10 vuotta sitten
vanhempi
commit
d7c9a97e8d
1 muutettua tiedostoa jossa 7 lisäystä ja 0 poistoa
  1. 7
    0
      index.html

+ 7
- 0
index.html Näytä tiedosto

@@ -226,6 +226,13 @@
226 226
       if (!config.disableThirdPartyRequests) {
227 227
         [
228 228
           'https://api.callstats.io/static/callstats.min.js',
229
+          // FIXME The implementation provided by analytics.js starts an
230
+          // asynchronous download of the Google Analytics integration.
231
+          // Unfortunately, modules/statistics/AnalyticsAdapter.js has already
232
+          // made the decision to not use it at the current point of the
233
+          // execution and has initialized itself with the NoopAnalytics
234
+          // implementation i.e. the implementation of the method
235
+          // AnalyticsAdapter.sendEvent will amount to nothing.
229 236
           'analytics.js?v=1'
230 237
         ].forEach(function(extSrc) {
231 238
           var extScript = document.createElement('script');

Loading…
Peruuta
Tallenna