浏览代码

fix(suboptimal-browser): remove inserting of app name in notification

This prevents inserting any user overridden APP_NAME
values into html. A new translation key is being used
to immediately stop non-english languages from using the
problematic string.

Also tweaked the copy to remove the "eer" and fix
some grammar.
j8
Leonard Kim 6 年前
父节点
当前提交
e8eb7e1e1f
共有 2 个文件被更改,包括 3 次插入6 次删除
  1. 1
    1
      lang/main.json
  2. 2
    5
      react/features/conference/functions.js

+ 1
- 1
lang/main.json 查看文件

429
         "somebody": "Somebody",
429
         "somebody": "Somebody",
430
         "startSilentTitle": "You joined with no audio output!",
430
         "startSilentTitle": "You joined with no audio output!",
431
         "startSilentDescription": "Rejoin the meeting to enable audio",
431
         "startSilentDescription": "Rejoin the meeting to enable audio",
432
-        "suboptimalExperienceDescription": "Eer... we are afraid your experience with {{appName}} isn't going to be that great here. We are looking for ways to improve this but, until then, please try using one of the <a href='static/recommendedBrowsers.html' target='_blank'>fully supported browsers</a>.",
432
+        "suboptimalBrowserWarning": "We are afraid your meeting experience isn't going to be that great here. We are looking for ways to improve this, but until then please try using one of the <a href='static/recommendedBrowsers.html' target='_blank'>fully supported browsers</a>.",
433
         "suboptimalExperienceTitle": "Browser Warning",
433
         "suboptimalExperienceTitle": "Browser Warning",
434
         "unmute": "Unmute",
434
         "unmute": "Unmute",
435
         "newDeviceCameraTitle": "New camera detected",
435
         "newDeviceCameraTitle": "New camera detected",

+ 2
- 5
react/features/conference/functions.js 查看文件

2
 import { isSuboptimalBrowser } from '../base/environment';
2
 import { isSuboptimalBrowser } from '../base/environment';
3
 import { toState } from '../base/redux';
3
 import { toState } from '../base/redux';
4
 
4
 
5
-import { getName } from '../app';
6
 import {
5
 import {
7
     areThereNotifications,
6
     areThereNotifications,
8
     showWarningNotification
7
     showWarningNotification
24
                     titleKey: 'notify.suboptimalExperienceTitle',
23
                     titleKey: 'notify.suboptimalExperienceTitle',
25
                     description: translateToHTML(
24
                     description: translateToHTML(
26
                         t,
25
                         t,
27
-                        'notify.suboptimalExperienceDescription',
28
-                        {
29
-                            appName: getName()
30
-                        })
26
+                        'notify.suboptimalBrowserWarning'
27
+                    )
31
                 }
28
                 }
32
             )
29
             )
33
         );
30
         );

正在加载...
取消
保存