Pārlūkot izejas kodu

Merge pull request #660 from jitsi/fix-user-cancel-reject-handling

Handle Promise.reject for user cancel case
master
hristoterezov 9 gadus atpakaļ
vecāks
revīzija
064917886e

+ 31
- 15
modules/UI/authentication/RoomLocker.js Parādīt failu

25
             function (e, v, m, f) {
25
             function (e, v, m, f) {
26
                 if (v && f.lockKey) {
26
                 if (v && f.lockKey) {
27
                     resolve(UIUtil.escapeHtml(f.lockKey));
27
                     resolve(UIUtil.escapeHtml(f.lockKey));
28
-                } else {
29
-                    reject();
28
+                }
29
+                else {
30
+                    reject(messageHandler.CANCEL);
30
                 }
31
                 }
31
             },
32
             },
32
             null, null, 'input:first'
33
             null, null, 'input:first'
58
                 if (v && f.lockKey) {
59
                 if (v && f.lockKey) {
59
                     resolve(UIUtil.escapeHtml(f.lockKey));
60
                     resolve(UIUtil.escapeHtml(f.lockKey));
60
                 } else {
61
                 } else {
61
-                    reject();
62
+                    reject(messageHandler.CANCEL);
62
                 }
63
                 }
63
             },
64
             },
64
             ':input:first'
65
             ':input:first'
79
                 if (v) {
80
                 if (v) {
80
                     resolve();
81
                     resolve();
81
                 } else {
82
                 } else {
82
-                    reject();
83
+                    reject(messageHandler.CANCEL);
83
                 }
84
                 }
84
             }
85
             }
85
         );
86
         );
146
          * @returns {Promise}
147
          * @returns {Promise}
147
          */
148
          */
148
         askToUnlock () {
149
         askToUnlock () {
149
-            return askToUnlock().then(function () {
150
-                return lock();
151
-            }).then(function () {
150
+            return askToUnlock().then(
151
+                () => { return lock(); }
152
+            ).then(function () {
152
                 AnalyticsAdapter.sendEvent('toolbar.lock.disabled');
153
                 AnalyticsAdapter.sendEvent('toolbar.lock.disabled');
153
-            });
154
+            }).catch(
155
+                reason => {
156
+                    if (reason !== messageHandler.CANCEL)
157
+                        console.error(reason);
158
+                }
159
+            );
154
         },
160
         },
155
 
161
 
156
         /**
162
         /**
159
          * @returns {Promise}
165
          * @returns {Promise}
160
          */
166
          */
161
         askToLock () {
167
         askToLock () {
162
-            return askForNewPassword().then(function (newPass) {
163
-                return lock(newPass);
164
-            }).then(function () {
168
+            return askForNewPassword().then(
169
+                newPass => { return lock(newPass);}
170
+            ).then(function () {
165
                 AnalyticsAdapter.sendEvent('toolbar.lock.enabled');
171
                 AnalyticsAdapter.sendEvent('toolbar.lock.enabled');
166
-            });
172
+            }).catch(
173
+                reason => {
174
+                    if (reason !== messageHandler.CANCEL)
175
+                        console.error(reason);
176
+                }
177
+            );
167
         },
178
         },
168
 
179
 
169
         /**
180
         /**
170
          * Asks user for required conference password.
181
          * Asks user for required conference password.
171
          */
182
          */
172
         requirePassword () {
183
         requirePassword () {
173
-            return askForPassword().then(function (newPass) {
174
-                password = newPass;
175
-            });
184
+            return askForPassword().then(
185
+                newPass => { password = newPass; }
186
+            ).catch(
187
+                reason => {
188
+                    if (reason !== messageHandler.CANCEL)
189
+                        console.error(reason);
190
+                }
191
+            );
176
         },
192
         },
177
 
193
 
178
         /**
194
         /**

+ 15
- 5
modules/UI/recording/Recording.js Parādīt failu

78
                             return false;
78
                             return false;
79
                         }
79
                         }
80
                     } else {
80
                     } else {
81
-                        reject();
81
+                        reject(APP.UI.messageHandler.CANCEL);
82
                         dialog.close();
82
                         dialog.close();
83
                         return false;
83
                         return false;
84
                     }
84
                     }
97
                 submit: function (e, v, m, f) {
97
                 submit: function (e, v, m, f) {
98
                     e.preventDefault();
98
                     e.preventDefault();
99
                     if (v === 0) {
99
                     if (v === 0) {
100
-                        reject();
100
+                        reject(APP.UI.messageHandler.CANCEL);
101
                         dialog.close();
101
                         dialog.close();
102
                     } else {
102
                     } else {
103
                         dialog.goToState('state0');
103
                         dialog.goToState('state0');
128
                 if (v && f.recordingToken) {
128
                 if (v && f.recordingToken) {
129
                     resolve(UIUtil.escapeHtml(f.recordingToken));
129
                     resolve(UIUtil.escapeHtml(f.recordingToken));
130
                 } else {
130
                 } else {
131
-                    reject();
131
+                    reject(APP.UI.messageHandler.CANCEL);
132
                 }
132
                 }
133
             },
133
             },
134
             null,
134
             null,
282
                         _requestLiveStreamId().then((streamId) => {
282
                         _requestLiveStreamId().then((streamId) => {
283
                             self.eventEmitter.emit( UIEvents.RECORDING_TOGGLED,
283
                             self.eventEmitter.emit( UIEvents.RECORDING_TOGGLED,
284
                                 {streamId: streamId});
284
                                 {streamId: streamId});
285
-                        });
285
+                        }).catch(
286
+                            reason => {
287
+                                if (reason !== APP.UI.messageHandler.CANCEL)
288
+                                    console.error(reason);
289
+                            }
290
+                        );
286
                     else {
291
                     else {
287
                         if (self.predefinedToken) {
292
                         if (self.predefinedToken) {
288
                             self.eventEmitter.emit( UIEvents.RECORDING_TOGGLED,
293
                             self.eventEmitter.emit( UIEvents.RECORDING_TOGGLED,
293
                         _requestRecordingToken().then((token) => {
298
                         _requestRecordingToken().then((token) => {
294
                             self.eventEmitter.emit( UIEvents.RECORDING_TOGGLED,
299
                             self.eventEmitter.emit( UIEvents.RECORDING_TOGGLED,
295
                                 {token: token});
300
                                 {token: token});
296
-                        });
301
+                        }).catch(
302
+                            reason => {
303
+                                if (reason !== APP.UI.messageHandler.CANCEL)
304
+                                    console.error(reason);
305
+                            }
306
+                        );
297
                     }
307
                     }
298
                     break;
308
                     break;
299
                 }
309
                 }

+ 2
- 1
modules/UI/util/MessageHandler.js Parādīt failu

10
 var notificationsEnabled = true;
10
 var notificationsEnabled = true;
11
 
11
 
12
 var messageHandler = (function(my) {
12
 var messageHandler = (function(my) {
13
-
13
+    my.OK = "dialog.OK",
14
+    my.CANCEL = "dialog.Cancel",
14
     /**
15
     /**
15
      * Shows a message to the user.
16
      * Shows a message to the user.
16
      *
17
      *

Notiek ielāde…
Atcelt
Saglabāt