Procházet zdrojové kódy

Merge pull request #1114 from jitsi/fix_page_reload_log

Log the page reload from one place
master
bgrozev před 8 roky
rodič
revize
38e44440d0
2 změnil soubory, kde provedl 7 přidání a 5 odebrání
  1. 0
    5
      conference.js
  2. 7
    0
      modules/UI/reload_overlay/PageReloadOverlay.js

+ 0
- 5
conference.js Zobrazit soubor

370
 
370
 
371
         case ConferenceErrors.FOCUS_LEFT:
371
         case ConferenceErrors.FOCUS_LEFT:
372
         case ConferenceErrors.VIDEOBRIDGE_NOT_AVAILABLE:
372
         case ConferenceErrors.VIDEOBRIDGE_NOT_AVAILABLE:
373
-            // Log the page reload event
374
-            // FIXME (CallStats - issue) this event will not make it to
375
-            // the CallStats, because the log queue is not flushed, before
376
-            // "fabric terminated" is sent to the backed
377
-            APP.conference.logEvent('page.reload');
378
             // FIXME the conference should be stopped by the library and not by
373
             // FIXME the conference should be stopped by the library and not by
379
             // the app. Both the errors above are unrecoverable from the library
374
             // the app. Both the errors above are unrecoverable from the library
380
             // perspective.
375
             // perspective.

+ 7
- 0
modules/UI/reload_overlay/PageReloadOverlay.js Zobrazit soubor

116
         if (!overlay) {
116
         if (!overlay) {
117
             overlay = new PageReloadOverlayImpl(timeoutSeconds);
117
             overlay = new PageReloadOverlayImpl(timeoutSeconds);
118
         }
118
         }
119
+        // Log the page reload event
120
+        if (!this.isVisible()) {
121
+            // FIXME (CallStats - issue) this event will not make it to
122
+            // the CallStats, because the log queue is not flushed, before
123
+            // "fabric terminated" is sent to the backed
124
+            APP.conference.logEvent('page.reload');
125
+        }
119
         overlay.show();
126
         overlay.show();
120
     }
127
     }
121
 };
128
 };

Načítá se…
Zrušit
Uložit