Browse Source

fix(hangup): truthy check for deviceChangeListener before removing it (#3235)

It can be that deviceChangeListener is never defined because
the isDeviceList call never completes. On hangup, that would
cause an error to be thrown within lib-jitsi-meet because of
an attempt to remove an undefined event handler. That is
what happens on Safari right now.
master
virtuacoplenny 7 years ago
parent
commit
485ff81443
No account linked to committer's email address
1 changed files with 5 additions and 3 deletions
  1. 5
    3
      conference.js

+ 5
- 3
conference.js View File

2479
         APP.UI.removeLocalMedia();
2479
         APP.UI.removeLocalMedia();
2480
 
2480
 
2481
         // Remove unnecessary event listeners from firing callbacks.
2481
         // Remove unnecessary event listeners from firing callbacks.
2482
-        JitsiMeetJS.mediaDevices.removeEventListener(
2483
-            JitsiMediaDevicesEvents.DEVICE_LIST_CHANGED,
2484
-            this.deviceChangeListener);
2482
+        if (this.deviceChangeListener) {
2483
+            JitsiMeetJS.mediaDevices.removeEventListener(
2484
+                JitsiMediaDevicesEvents.DEVICE_LIST_CHANGED,
2485
+                this.deviceChangeListener);
2486
+        }
2485
 
2487
 
2486
         let requestFeedbackPromise;
2488
         let requestFeedbackPromise;
2487
 
2489
 

Loading…
Cancel
Save