Bladeren bron

Adds new text for Firefox screen-sharing permission denied error.

master
damencho 7 jaren geleden
bovenliggende
commit
ea431ca90c
2 gewijzigde bestanden met toevoegingen van 19 en 2 verwijderingen
  1. 17
    2
      conference.js
  2. 2
    0
      lang/main.json

+ 17
- 2
conference.js Bestand weergeven

@@ -1721,8 +1721,23 @@ export default {
1721 1721
         let titleKey;
1722 1722
 
1723 1723
         if (error.name === JitsiTrackErrors.PERMISSION_DENIED) {
1724
-            descriptionKey = 'dialog.screenSharingPermissionDeniedError';
1725
-            titleKey = 'dialog.screenSharingFailedToInstallTitle';
1724
+
1725
+            // in FF the only option for user is to deny access temporary or
1726
+            // permanently and we only receive permission_denied
1727
+            // we always show some info cause in case of permanently, no info
1728
+            // shown will be bad experience
1729
+            //
1730
+            // TODO: detect interval between requesting permissions and received
1731
+            // error, this way we can detect user interaction which will have
1732
+            // longer delay
1733
+            if (JitsiMeetJS.util.browser.isFirefox()) {
1734
+                descriptionKey
1735
+                    = 'dialog.screenSharingFirefoxPermissionDeniedError';
1736
+                titleKey = 'dialog.screenSharingFirefoxPermissionDeniedTitle';
1737
+            } else {
1738
+                descriptionKey = 'dialog.screenSharingPermissionDeniedError';
1739
+                titleKey = 'dialog.screenSharingFailedToInstallTitle';
1740
+            }
1726 1741
         } else {
1727 1742
             descriptionKey = 'dialog.screenSharingFailedToInstall';
1728 1743
             titleKey = 'dialog.screenSharingFailedToInstallTitle';

+ 2
- 0
lang/main.json Bestand weergeven

@@ -293,6 +293,8 @@
293 293
         "permissionDenied": "Permission Denied",
294 294
         "screenSharingFailedToInstall": "Oops! Your screen sharing extension failed to install.",
295 295
         "screenSharingFailedToInstallTitle": "Screen sharing extension failed to install",
296
+        "screenSharingFirefoxPermissionDeniedError": "Something went wrong while we were trying to share your screen. Please make sure that you have given us permission to do so. ",
297
+        "screenSharingFirefoxPermissionDeniedTitle": "Oops! We weren’t able to start screen sharing!",
296 298
         "screenSharingPermissionDeniedError": "Oops! Something went wrong with your screen sharing extension permissions. Please reload and try again.",
297 299
         "cameraUnsupportedResolutionError": "Your camera does not support required video resolution.",
298 300
         "cameraUnknownError": "Cannot use camera for an unknown reason.",

Laden…
Annuleren
Opslaan